Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-340: Cover art embedding will overwrite existing ones #462

Closed
wants to merge 3 commits into from

Conversation

rahul-raturi
Copy link
Contributor

No description provided.

@@ -451,7 +451,17 @@ def get_files_from_objects(self, objects, save=False):
def save(self, objects):
"""Save the specified objects."""
files = self.get_files_from_objects(objects, save=True)
for file in files:
coverOverwritePrompt = config.setting["cover_overwrite_prompt"]
for file, obj in zip(files, objects):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this, but the lengths of objects and files are not always the same (a track can be associated with multiple files and an album/cluster with multiple tracks).

@mineo
Copy link
Member

mineo commented Mar 10, 2016

I don't embed images and always use the ones from MB, so I'm not sure how useful this is for people without being able to compare the images when the message box is shown.

@rahul-raturi
Copy link
Contributor Author

rahul-raturi commented May 24, 2016

Umm, @zas, can you remove the "Ready to merge" label please. I was hoping to get this visual feedback PR merged before I get back on this. As @mineo said, it would be better to allow comparing images before displaying the prompt. Displaying cover changes in the Metadatabox should be enough IMO (rather than displaying them in the prompt too).
Besides, I haven't tested it completely, so it requires a little bit more work.

Edit: Maybe a "Needs more work" label?

@samj1912
Copy link
Collaborator

It's been almost 2 years since this was updated. Closing this with a 'Needs more work' tag. You can reopen this if you want to continue working on it. Also we have updated to Qt5 and py3 so be mindful of that while reworking on this PR.

@samj1912 samj1912 closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants