Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-1041: Replace Ok button text by Make It So! in Options dialog #668

Merged
merged 1 commit into from Mar 31, 2017

Conversation

zas
Copy link
Collaborator

@zas zas commented Mar 30, 2017

@@ -84,7 +84,9 @@ def __init__(self, default_page=None, parent=None):
self.ui.reset_button = QtGui.QPushButton(_("Restore &Defaults"))
self.ui.reset_button.setToolTip(_("Reset all settings for current option page"))

self.ui.buttonbox.addButton(StandardButton(StandardButton.OK), QtGui.QDialogButtonBox.AcceptRole)
Copy link
Contributor

@Sophist-UK Sophist-UK Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# April fool
self.ui.buttonbox.addButton(StandardButton(StandardButton.OK).setText(_("Make It So!")), QtGui.QDialogButtonBox.AcceptRole)

?

Copy link
Collaborator Author

@zas zas Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sophist-UK : it's not an April fool.

Copy link
Contributor

@Sophist-UK Sophist-UK Mar 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. :-)

@zas zas merged commit 817ffd3 into metabrainz:master Mar 31, 2017
1 check passed
@mineo
Copy link
Member

@mineo mineo commented Apr 6, 2017

I have to admit that I don't like this. It's bad enough to make one of the most important buttons of the whole application an easter egg that not everybody might get, but this is not even translated in a single language. I'm sorry, but do we expect everybody using any of the enabled languages in picard to get english star trek references?

@Sophist-UK
Copy link
Contributor

@Sophist-UK Sophist-UK commented Apr 6, 2017

Admittedly it is a bit geeky - ok, a lot geeky - and of course, @mineo's common sense should prevail.

But I hope it doesn't - a little quirkiness and individuality is becoming a rarity these days.

Of course, @mineo can always submit translations so that "Make it so" translates to OK in every language other than English. ;-)

@Sophist-UK
Copy link
Contributor

@Sophist-UK Sophist-UK commented Apr 6, 2017

P.S. Should Make it so be in quotation marks "Make it so"?

@mineo
Copy link
Member

@mineo mineo commented Apr 7, 2017

Of course, @mineo can always submit translations so that "Make it so" translates to OK in every language other than English. ;-)

I could, but would already fail at providing one for my native language german because AFAIK "Make it so" is not Picards catch-phrase in german and doesn't have a consistent translation across all episodes.

@Sophist-UK
Copy link
Contributor

@Sophist-UK Sophist-UK commented Apr 14, 2017

Thinking again about this - how about the button text being "OK, Make it so" as a compromise - because some people won't get the reference and will wonder where the OK button is.

@zas zas deleted the MakeItSo branch Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants