-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BitcoinExtKey encrypt with password implementation is missing #155
Comments
There is no standard for encrypting a BitcoinExtKey. If encryption with password is needed for an ExtKey then the best is to use BIP39 with the Mnemonic class. |
That is a transparent box design: Designing the system in terms of how it will look from the inside. |
After playing with Mnemonic I think I understand what the design should be, please correct me if I'm wrong: If I am finally on the right track here, I see how it would be a bad idea to implement encryption directly to the BitcoinExtKey, what I recommended in my previous comment (however it will still cost a lot of developer time for others until they finally figure this out, if they don't start out with Mnemonic right away.) Is the mnemonic encryption supported somehow by NBitoin? (Currently I am using this StringCipher: http://stackoverflow.com/a/10177020/2061103) |
Correct, I explain the Mnemonic it very well in my book http://n.bitcoin.ninja/ takes a look. |
One can easily from BitcoinExtKey a BitcoinSecret, but not the other way around.
Although I am not sure why, but I take it as the expected behaviour. In this case the need arises for encryption and decryption of BitcoinExtKey.
The text was updated successfully, but these errors were encountered: