Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexing fails on giant modules #709

Open
haarg opened this issue Jul 4, 2017 · 11 comments
Open

Indexing fails on giant modules #709

haarg opened this issue Jul 4, 2017 · 11 comments

Comments

@haarg
Copy link
Member

haarg commented Jul 4, 2017

https://metacpan.org/release/DCANTRELL/Number-Phone-3.4001 includes a module Number::Phone::UK::Data that is 96MB. This is binary content in a __DATA__ section. metacpan fails to index this file, eventually timing out. We should be able to detect content like this and skip the file, or at least time out on an individual file and continue with the rest of the dist.

@oalders
Copy link
Member

oalders commented Jul 6, 2017

Ping @DrHyde (FYI)

@theory
Copy link
Contributor

theory commented Jul 6, 2017

Ah. Curious, I could swear it was indexed in the past…

@oalders
Copy link
Member

oalders commented Jul 6, 2017

It was. :) FWIW Number-Phone-3.4000.tar.gz does not time out.

@DrHyde
Copy link

DrHyde commented Jul 6, 2017

Pong!

I assume that it tipped over some limit in the most recent release. IIRC there was a similar problem a while back where it was trying to find POD in the __DATA__, so if you can find whatever the fix was for that you may be able to re-use it.

@theory
Copy link
Contributor

theory commented Jul 20, 2017

Looks like Number::Phone::UK::Data was 65M in 3.4000. Any chance some buffer size could be temporarily increased to get this one release indexed, assuming @DrHyde switches to a sharedir in the next release? This is killing my build process. :-(

@oalders
Copy link
Member

oalders commented Jul 20, 2017

That would be fine with me. @mickeyn any idea where we'd need to do this?

@mickeyn
Copy link
Contributor

mickeyn commented Jul 20, 2017

if this is a one-off... i can hack something manually

@mickeyn
Copy link
Contributor

mickeyn commented Jul 20, 2017

done. is it better now? https://metacpan.org/release/DCANTRELL/Number-Phone-3.4001

@theory
Copy link
Contributor

theory commented Jul 20, 2017

Yep, thanks!

@DrHyde
Copy link

DrHyde commented Jul 21, 2017

FYI Number-Phone-3.4001_01 is on its way to the CPAN. Assuming that it doesn't break metacpan, and the CPAN testers are OK with it, that should mean that I've fixed it and the sharedir magic will be in the next non-dev release.

@DrHyde
Copy link

DrHyde commented Jul 27, 2017

3.4001_01 wouldn't build on Windows, 3.4001_02 does, and metacpan indexed it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants