New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script to read data from cpantesters api #765

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@preaction
Contributor

preaction commented Nov 17, 2017

This script reads the release test summary data from the CPAN Testers
API (http://api.cpantesters.org) instead of the SQLite database (which
has been prone to problems).

Once this is merged, we'll have to change over the update process to use this script, and then once this process proves stable, we can remove the old script.

add script to read data from cpantesters api
This script reads the release test summary data from the CPAN Testers
API (http://api.cpantesters.org) instead of the SQLite database (which
has been prone to problems).

@oalders oalders self-assigned this Nov 17, 2017

@oalders

This comment has been minimized.

Show comment
Hide comment
@oalders

oalders Nov 17, 2017

Member

LGTM. Just wondering why there's so much logic in a shell script? :)

Member

oalders commented Nov 17, 2017

LGTM. Just wondering why there's so much logic in a shell script? :)

@oalders oalders requested a review from mickeyn Nov 17, 2017

@oalders oalders removed their assignment Nov 17, 2017

@oalders oalders merged commit bb96e1a into master Nov 17, 2017

3 checks passed

code-analysis/kritika Kritika analysis finished
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@oalders oalders deleted the preaction/cpantesters-api branch Nov 17, 2017

@preaction

This comment has been minimized.

Show comment
Hide comment
@preaction

preaction Nov 17, 2017

Contributor

why there's so much logic in a shell script?

I learned it from you, okay?! I learned it from watching you!!!!!!!!1

But no, that was a pain. I'm 100% open to suggestions. It's mostly like that so that adding new modules is, like the other cpantesters fake db bin script, easy to do with a single line. I could change it such that it was just a Perl script that fetched the thing and only wrote the things we wanted instead...

Contributor

preaction commented Nov 17, 2017

why there's so much logic in a shell script?

I learned it from you, okay?! I learned it from watching you!!!!!!!!1

But no, that was a pain. I'm 100% open to suggestions. It's mostly like that so that adding new modules is, like the other cpantesters fake db bin script, easy to do with a single line. I could change it such that it was just a Perl script that fetched the thing and only wrote the things we wanted instead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment