Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Honor =encoding directive when decoding raw resonses
- Loading branch information
Showing
2 changed files
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
502a86f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See metacpan/metacpan-api#258 (comment)
I don't think we should apply that level of magic.
502a86f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I wasn't entirely sure about this either, but the way the page got screwed up without it didn't seem right either.
We're telling the browser that we're providing utf-8, and then instead we're serving up mixed encodings.
Well actually i guess that's not true. Without the detection, we attempt to decode those bytes as utf-8 but that will fail,
so then the Catalyst plugin will treat the
euc-jp
encoded bytes aslatin1
chars and turns it into weird symbols and replacement characters.I am willing to revert this since it's neither 100% satisfactory nor 100% correct.
Besides, everyone should be using
UTF-8
, right? ;-)