Favorites not displaying on author page -- Give author type an updated timestamp as soon as PAUSE account is connected #852

Closed
mperry2 opened this Issue Jun 9, 2013 · 54 comments

Projects

None yet
@mperry2
mperry2 commented Jun 9, 2013

I favorited a distribution about a week ago but it's not listed as a favorite on my author page (https://metacpan.org/author/MPERRY). When I view the distribution that I favorited (https://metacpan.org/module/Finance::QIF) I can see that the favorite button is blue, which I assume means that the site knows I've clicked it and recorded it as a favorite.

Expected result:
My author page should list my favorites.

Actual result:
No favorites are listed on my author page.

@Lx
Lx commented Jul 20, 2013

I'm also interested in this issue as I'm facing the same problem.

@oalders
Member
oalders commented Jul 20, 2013

Just wanted to note that @Lx's author page is at https://metacpan.org/author/LXP

@stephenenelson

I am also facing the same issue.

@ranguard
Member

I think this is https://metacpan.org/about/faq ( Do you have multiple accounts? ) - please try that and comment on this ticket (for us to reopen) if that does not solve this issue.

@ranguard ranguard closed this Jan 18, 2014
@Lx
Lx commented Jan 18, 2014

I don't have multiple accounts, and am affected by this issue.

@stephenenelson

I don't have multiple accounts. I'm still not seeing any favorites.

@mperry2
mperry2 commented Jan 20, 2014

@ranguard Why did you close this bug report when the problem is not fixed? Please reopen the bug report.

@oalders oalders reopened this Jan 20, 2014
@oalders
Member
oalders commented Jan 20, 2014

Could everyone in this thread who would like to see this fixed please let us know what your PAUSE ids are?

@mperry2
mperry2 commented Jan 20, 2014

@oalders Thanks for reopening the report. My PAUSE id is MPERRY. Please let me know if there's any other information I can provide to help debug this problem.

@stephenenelson

My PAUSE id is STEPHEN.

On Jan 19, 2014, at 10:19 PM, Matt Perry notifications@github.com wrote:

@oalders Thanks for reopening the report. My PAUSE id is MPERRY. Please let me know if there's any other information I can provide to help debug this problem.


Reply to this email directly or view it on GitHub.

@ranguard
Member

@mperry2 please take the time to read the message i left when I closed this ticket, and also look at https://github.com/CPAN-API/metacpan-web/blob/master/CONTRIBUTING.md#when-are-issues-closed

@zoffixznet
Contributor

My PAUSE id is ZOFFIX

@damil
damil commented Jan 22, 2014

Same problem. My PAUSE id is DAMI.

@mperry2
mperry2 commented Jan 26, 2014

The entry in the FAQ about multiple accounts doesn't appear to be relevant to me. When I go to my settings page and then to identities, I see both PAUSE and GitHub as connected. I clicked to disconnect both of them so that I would no longer have any identities connected. I then chose to reconnect to Github. I had to fill in a captcha which the page said would allow me to ++ items. I successfully completed that.

Visiting https://metacpan.org/pod/Finance::QIF still shows the blue 1++ indicating I favored it eight months ago. However, https://metacpan.org/author/MPERRY still does not show any favorite distributions as I expect. Deselecting and reselecting the ++ button on Finance::QIF and reloading my author page made no difference. The favored distribution was not listed.

Please let me know if I can do anything else to help you debug this.

@omega
Contributor
omega commented Feb 4, 2014

Just a quick note after digging a bit. In Controller/Author.pm, we make a request to the backend for /author/<PAUSEID>. http://explorer.metacpan.org/?url=%2Fauthor%2FMPERRY&content= is the same in explorer. To get favourites we look for user in that JSON, which for MPERRY isn't there. For instance for NEILB it is there: http://explorer.metacpan.org/?url=/author/NEILB.

I don't know much about the backend, but it seems that the author document (PAUSE account for MPERRY) isn't linked to a user account for some reason?

@zoffixznet
Contributor

I just tried disconnecting pause and then relinking it; nothing changed. Using the explorer links above, the only difference I see between my account and NEILB's is that he's got this key: "user" : "6BCMBMlWQyqMDiV2OCo8Ag", while I don't.

P.S. also, connecting one account now seems to disconnect all the others. I had Facebook and PAUSE linked; now I can have just one or the other :| Weird.

@monken
Member
monken commented Feb 4, 2014

Please try again to disconnect pause, and remove all cookies for api.metacpan.org and metacpan.org. Log in with Facebook and connect with PAUSE. that should do the trick.

@zoffixznet
Contributor

Weeee \o/ Yes, that totally fixed both issues. Both Facebook and PAUSE are linked, and I got my Favorites list: https://metacpan.org/author/ZOFFIX

@Lx
Lx commented Feb 4, 2014

Because I'm not connected via Facebook, I adapted @monken's instructions slightly without success:

  1. Clear all cookies.
  2. Log into MetaCPAN via GitHub credentials.
  3. Disconnect PAUSE.
  4. Clear all cookies.
  5. Log into MetaCPAN via GitHub credentials.
  6. Request PAUSE connection.
  7. Click verification link received in email.

On clicking that link, I was presented with a blob of JSON (in my browser--possibly a bug in itself?):

{
   "looks_human" : true,
   "identity" : [
      {
         "name" : "pause",
         "extra" : {},
         "key" : "LXP"
      }
   ],
   "access_token" : [],
   "id" : "<redacted>"
}

My PAUSE account now remains disconnected, and so my favourites cannot appear on my author page.

@Lx
Lx commented Feb 4, 2014

After trying the above steps again the operation appeared to succeed, however my GitHub and Google accounts were disconnected. After logging out of MetaCPAN and back in again via GitHub, my GitHub and Google accounts are connected again, but not my PAUSE account.

@damil
damil commented Feb 4, 2014

Le 04.02.2014 15:44, Alex Peters a écrit :

After trying the above steps again the operation appeared to succeed, however my GitHub and Google accounts were disconnected. After logging out of MetaCPAN and back in again via GitHub, my GitHub and Google accounts are connected again, but not my PAUSE account.


I tried several times, clearing all cookies, logging with Github or
Google, without success.
Then suddenly it did work using the Google account, but I only saw one
favorite I entered months ago.
So I re-did the whole process, using the Github account, and now it
displays my recent favorites.

Somehow it seems that the favorites are stored in a strange way; not
associated with the PAUSE account, but the Github or Google account used
for login.

PAUSE id : DAMI

@mperry2
mperry2 commented Feb 12, 2014

This is now working properly for my account. I even see the items I favored before I opened this issue. What I did was

  1. Clear all my cookies.
  2. Close and reopen browser to make sure everything was cleared out.
  3. Log into metacpan (with github option)
  4. Go to identities. Only Github is connected. All others are disconnected.
  5. Check my favorites. None were listed.
  6. Go to identities and click Connect for PAUSE.
  7. Click on the link sent by email. I then went to identities. Github and PAUSE are connected.
  8. Check my favorites. Four items are now listed as I expect.

I disconnected from PAUSE and the favorites continued to be listed (hurrah!). I reconnected to PAUSE and they were still there. I added App::ack as a favorite and it showed up as I expected.

This is fixed for me. I hope those of you still having problems can find a solution.

@ranguard: should I close this issue or leave it open for those people who are still having problems?

@Lx
Lx commented Feb 12, 2014

@mperry2, please keep this issue open. I continue to experience problems.

Having followed @mperry2's steps up to Step 7 I am now only connected to PAUSE, not GitHub or Google. If I re-connect to GitHub I am only connected to GitHub and Google, not PAUSE.

Looks like internally I must have two MetaCPAN accounts or something, and my favourites are all defined under the GitHub/Google-linked account rather than PAUSE-linked account and I can't merge them so that I'm connected to them all at once.

@Lx
Lx commented Feb 12, 2014

Okay, I followed the steps again in the "Do you have multiple accounts?" FAQ entry and this solved my problem. I did in fact have two MetaCPAN accounts which needed merging. Here's what I did specifically to solve the problem in my case:

  1. Log into MetaCPAN using GitHub, since this is the account I most probably used to define all of my favourites previously.
  2. Attempt to connect PAUSE, clicking the link received in my email. This had the apparent effect of disconnecting my GitHub and Google accounts, but what it actually did was log me into my other MetaCPAN account to which my PAUSE account is already connected, but has no favourite definitions.
  3. Disconnect PAUSE. This secondary MetaCPAN account of mine now has no connections.
  4. Log out. Presumably the secondary account is now deleted because it has no connections.
  5. Log in again using GitHub.
  6. Attempt again to connect PAUSE, clicking the link received in my email. This time, because my PAUSE account is not linked to another MetaCPAN account, it is connected to my "main" MetaCPAN account and I am now connected to all of GitHub, Google and PAUSE from one MetaCPAN account.
  7. Check my author page and confirm that my favourites are indeed all defined there, which they are.
@damil
damil commented Feb 15, 2014

Le 12.02.2014 05:05, Alex Peters a écrit :

Okay, I followed the steps again in the "Do you have multiple
accounts?" FAQ https://metacpan.org/about/faq entry and this solved
my problem. I did in fact have two MetaCPAN accounts which needed
merging. Here's what I did specifically to solve the problem in my case:

[snip]

Hurrah! Worked for me too. Thanks for your detailed explanation. This
notion of "identities" was quite mysterious for me and the MetaCPAN doc
did not help much :-(

@ranguard
Member

So I think everyone is sorted? (@stephenenelson please try the above suggestions, if not please comment and we'll re-open), I've also added a link to this thread from the faq: 44ff52a to help future people

@ranguard ranguard closed this Feb 15, 2014
@stephenenelson

That appears to work for me. Thanks!

On Feb 15, 2014, at 10:25 AM, Leo Lapworth notifications@github.com wrote:

So I think everyone is sorted? (@stephenenelson please try the above suggestions, if not please comment and we'll re-open), I've also added a link to this thread from the faq: 44ff52a to help future people


Reply to this email directly or view it on GitHub.

@vanstyn
vanstyn commented Apr 24, 2014

I'm not sorted... I've followed the clear cookies, reconnect steps, etc, and I am left with a working connection to my PAUSE account (having started the process connected with Github) Everything seems to work, I can click to add/favorite packages just fine... I just can't see them later on; my Favorites page is still empty. Does it perhaps take longer to be populated with data, or should it be instant?

Also, as a side note, I have exactly 1 PAUSE account "vanstyn" which is the same as my Github account and I have only one of those, too

@oalders
Member
oalders commented Apr 24, 2014

@vanstyn There's no lag in having the favourites displayed. I'll re-open this issue for you.

@oalders oalders reopened this Apr 24, 2014
@ddoyle
ddoyle commented May 16, 2014

FYI: I had a PAUSE account but had never released a module. Never had my fav's show. Released my first module last week, favourited something. Still got nothing on my fav's page and I noticed the "X non-PAUSE users liked this" increment. I went to my accounts page, disconnected my PAUSE account, then re-connected PAUSE. Clicked the verify email, now I see my favourites.

@mrdvt92
mrdvt92 commented Sep 3, 2014

On my account MRDVT, I can reset it (disconnect, disconnect, logout, clear cache, close browser) and the author page will show my favorites for about 10-15 minutes. However, after returning to the site my favorites are no longer visible on the author page but they are still in the system as they appear as "1 non-PAUSE user(s)."

I'm not sure what is going on. I really which we could login in as PAUSE and forgo all of the other linking. It's actually quite trivial since PAUSE uses Basic Authentication at this URL https://pause.perl.org/pause/authenquery just proxy over to it and cache for a few hours or so.

@oalders
Member
oalders commented Sep 3, 2014

Is your profile information being reset at the same intervals as well? It sounds like a cron is misbehaving.

@mrdvt92
mrdvt92 commented Sep 8, 2014

I'm still having issues getting my favorites to stick on the Author page. How do I view the data for my accounts? And where is the code that handles display of favorites on the author page?

Here's my history.

  1. I want to log in with my PAUSE account but it is not an option.
  2. I accidentally logged in with my Google account one time it should NOT be linked to my meta::cpan account at all.
  3. I'm forced to login in with my GitHub account.
  4. Then I have to link to my PAUSE account.

When I return (sometimes 10 minutes some times next day), I'm logged in correctly with the GitHub account and linked PAUSE identity. However, none of my favorites are linked to my Author page.

I can disconnect and re-connect my Pause account and the favorites will show for a short while.

Thanks,
Mike

mrdvt92

@nicklangridge

I'm experiencing the same problem as Mike (mrdvt92)
Very frustrating.
I started to dig in the source but I don't really know where to look.

@oalders
Member
oalders commented Oct 2, 2014

@nicklangridge what is your PAUSE id?

@oalders
Member
oalders commented Oct 18, 2014

When I check NICKL's info in the API, I see:

{
   "dir" : "id/N/NI/NICKL",
   "name" : "Nick Langridge",
   "email" : [
      "nickl@cpan.org"
   ],
   "website" : [],
   "pauseid" : "NICKL",
   "gravatar_url" : "https://secure.gravatar.com/avatar/46666dab0b20c81e2aa6751470934dca?s=130&d=identicon"
}

First problem is that his user key is missing (wiped out), so we can't map the favorites back to his account.

The issue would likely be in MetaCPAN::Script::Author in the cpan-api repository. This is the code that is run via cron.

@oalders
Member
oalders commented Oct 18, 2014

After another look, I see that since NICKL has no "updated" key in his author profile, it will always be wiped out when the author cron runs again.

@nicklangridge can you run through the steps above again, but this time after you do so, go to this page https://metacpan.org/account/profile and click 'save profile' at the bottom of the page. Actually, save your profile before you reconnect just in case there's a timing issue with the cron running.

Could you let me know if that fixes things?

@oalders
Member
oalders commented Oct 18, 2014

@mrdvt92 it looks like a) your favorites are visible and b) you have an updated profile, so maybe this is the bit of info we were missing.

We need to mark author profiles as "updated" as soon as a PAUSE account is linked to the profile.

@oalders oalders changed the title from Favorites not displaying on author page to Favorites not displaying on author page -- Give author type an updated timestamp as soon as PAUSE account is connected Oct 18, 2014
@nicklangridge

@oalders After re-link my identities I didn't seem to have any favourites at all. But I added new favourites and used 'save profile' as suggested. They seem to be sticking this time, thanks. Will report back if they go again.

@ranguard ranguard closed this Nov 13, 2014
@oalders
Member
oalders commented Nov 13, 2014

@nicklangridge Thanks for the update!

@vanstyn
vanstyn commented Feb 11, 2015

My Account is 'VANSTYN' and I still have no favorites. I just disconnected and re-linked with my PAUSE account, and tried updating and saving my profile, and then gave a few more modules ++ ... still nothing, favorites show up blank as always

@vlyon
vlyon commented Jun 17, 2015

I'm having the same issue, can't link my GitHub (vlyon) account and my PAUSE (vlyon) account.

@Relequestual

Also having this issue. Logged a new issue for not being able to link both accounts at the same time #1579

@bes-internal

Sing in with github first time at all. No PAUSE account. Click on fav and enter a captcha at new page. Num in search result is increment but favorites page at account is empty and fav num at module page not change

@perlpunk

The ++ thing never worked for me, but I just didn't bother to find out why. Now I wanted to find out and found this issue.
The instructions in
#852 (comment)
worked for me. There should be at least an FAQ entry that addresses this (the already existing entry about multiple accounts did not help me in any way).

@p-alik
p-alik commented May 10, 2016

The ++ thing never worked for me and still doesn't work.
No matter what I do, favorites page is empty

@vanstyn
vanstyn commented May 10, 2016

same here

@s31tz
s31tz commented May 25, 2016 edited

I see my favorites under https://metacpan.org/account/favorite/list but not on my authors page https://metacpan.org/author/FSEITZ. I saved my profile before and after (re)connecting to PAUSE but nothing changed. Any ideas?

@p-alik
p-alik commented May 25, 2016

As result of #852 both pages https://metacpan.org/account/favorite/list and author page (pause account palik) are empty in my case.

@s31tz
s31tz commented May 26, 2016

After I uploaded a new distribution, my favorites are now visible on my authors page. It seems to me, that a causal connection exists.

@p-alik
p-alik commented May 26, 2016

after reconnecting to pause I see favorites on account favorite list but author page shows

No favorite distributions from XXX could be found

@p-alik
p-alik commented May 26, 2016

magic world! ++ works now as well

@s31tz
s31tz commented May 26, 2016

Congratulations ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment