From 800c839c9e489a441c9874c1205b63fb7074f19d Mon Sep 17 00:00:00 2001
From: Graham Knop <haarg@haarg.org>
Date: Sun, 19 Mar 2017 21:46:48 +0100
Subject: [PATCH 1/2] fix login for non-pause users

Logging in as a user that didn't have a PAUSE account connected was
working, but the code to fetch the favorites list (which controls the
login menu) wasn't interpreting that correctly.  The favorites code was
checking for a "profile", which only exists for PAUSE users.

Instead, use the normal authentication routines and the resulting user
object.
---
 .../Web/Controller/Account/Favorite.pm        | 27 ++++++++-----------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/lib/MetaCPAN/Web/Controller/Account/Favorite.pm b/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
index 838417ea56..eba213b157 100644
--- a/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
+++ b/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
@@ -6,18 +6,13 @@ BEGIN { extends 'MetaCPAN::Web::Controller' }
 sub auto : Private {
     my ( $self, $c ) = @_;
 
-    # Needed to clear the cache
-    my $user = $c->model('API::User')->get_profile( $c->token )->recv;
-
-    # Probably we shouldn't be getting to this point without a defined user,
-    # but sometimes we do.  Might have been an issue with the v0 => v1
-    # migration.
-
-    $c->detach('/forbidden') unless $user && $user->{user};
-
-    $c->stash->{user} = $user;
-
-    return 1;
+    if ( my $token = $c->token ) {
+        $c->authenticate( { token => $token } );
+    }
+    unless ( $c->user_exists ) {
+        $c->forward('/forbidden');
+    }
+    return $c->user_exists;
 }
 
 sub add : Local : Args(0) {
@@ -78,18 +73,18 @@ sub list_as_json : Local : Args(0) {
 sub _cache_key_for_user {
     my ( $self, $c ) = @_;
 
-    my $user = $c->stash->{user};
+    my $user = $c->user;
 
-    return 'user/' . $user->{user};
+    return 'user/' . $user->id;
 }
 
 sub _add_fav_list_to_stash {
     my ( $self, $c, $size ) = @_;
 
-    my $user = $c->stash->{user};
+    my $user = $c->user;
 
     my $faves_cv
-        = $c->model('API::Favorite')->by_user( $user->{user}, $size );
+        = $c->model('API::Favorite')->by_user( $user->id, $size );
     my $faves_data = $faves_cv->recv;
     my $faves      = [
         sort { $b->{date} cmp $a->{date} }

From e540d82af56b98e619b7e9c42e1ea42890d5e153 Mon Sep 17 00:00:00 2001
From: Olaf Alders <olaf@wundersolutions.com>
Date: Sun, 19 Mar 2017 23:15:29 -0400
Subject: [PATCH 2/2] Tidy.

---
 lib/MetaCPAN/Web/Controller/Account/Favorite.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/MetaCPAN/Web/Controller/Account/Favorite.pm b/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
index eba213b157..60cf303e9c 100644
--- a/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
+++ b/lib/MetaCPAN/Web/Controller/Account/Favorite.pm
@@ -83,8 +83,7 @@ sub _add_fav_list_to_stash {
 
     my $user = $c->user;
 
-    my $faves_cv
-        = $c->model('API::Favorite')->by_user( $user->id, $size );
+    my $faves_cv   = $c->model('API::Favorite')->by_user( $user->id, $size );
     my $faves_data = $faves_cv->recv;
     my $faves      = [
         sort { $b->{date} cmp $a->{date} }