New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to PrePAN from release page #384

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kentaro
Member

kentaro commented Nov 9, 2011

I made some modification according the the discussion below:

What I've done are:

  • Retrieve module metadata from META.(yml|json)
  • Add a link to PrePAN page if available

Please look into the diff and discuss if it should be merged.

@kentaro

This comment has been minimized.

Member

kentaro commented Nov 9, 2011

I added a dependency for YAML::Tiny. But I don't know where I should add the prerequisite.

@kentaro

This comment has been minimized.

Member

kentaro commented Nov 9, 2011

Oh I haven't known that CPAN META Spec 2 permits a key like `x_prepan' under resource.

But, for example, Module::Install::Metadata raise an error if non-official keys don't include at least one upper-case char according to the Spec 1.4.

@rwstauner

This comment has been minimized.

Member

rwstauner commented Nov 9, 2011

you can put prereqs with the others in dist.ini

@oalders

This comment has been minimized.

Member

oalders commented Nov 9, 2011

I think you could solve the error with X_prepan. I think I've seen that in Meta files. You could also consider if there's other prepan info you'd want in there, like the author URL.

@monken

This comment has been minimized.

Member

monken commented Nov 9, 2011

I think you can stick x_prepan at the root level, but not under resources. One negative thing about this patch is, that for the release page we add an additional request, which adds some latency. And since only a tiny fraction uses PrePAN (and will ship their distribution with the x_prepan flag), I'm not sure that's actually worth it.

@monken

This comment has been minimized.

Member

monken commented Nov 9, 2011

I would like to add that an alternative would be to stick the contents of the META file in our index directly. That would make searching on those fields possible and we wouldn't have to add a request to /source.

@oalders

This comment has been minimized.

Member

oalders commented Nov 9, 2011

Indexing the META file would be great, I think. Lots of great use cases for that.

@monken

This comment has been minimized.

Member

monken commented Nov 9, 2011

it's called metacpan after all ;-)

@oalders

This comment has been minimized.

Member

oalders commented Nov 9, 2011

@kentaro

This comment has been minimized.

Member

kentaro commented Nov 10, 2011

Indexing META files seems to be so great! It's the right way, I think.

@oalders oalders referenced this pull request Nov 17, 2011

Closed

linking prePan #381

@oalders

This comment has been minimized.

Member

oalders commented Jul 31, 2012

@kentaro metacpan/metacpan-api#145 is now complete, so this patch can now be reworked to use the metadata available via the API.

@kentaro kentaro closed this Jun 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment