Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

last-week, last-month vs. last 7 days, last 30 days #22

Open
helix123 opened this Issue Jun 26, 2017 · 0 comments

Comments

Projects
None yet
1 participant

As it seems the values last-week, last-month of the when argument are really meant to mean last 7 days and last 30 days, respectively. Given the current names, one could suspect to get the last full week (Mon - Sun) and the last full month (1 to 28, 29, 30, or 31 days).

Thus, my suggestion is to introduce more explicit names (last-7-days, last-30-days), maybe additionally (and discourage use of last-week, last-month but allow for them as back-compatiblilty).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment