/cranlogs

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Check http responses status before proceeding. #11

Merged
merged 1 commit into from Sep 5, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jeroen @gaborcsardi
@jeroen
Member

jeroen commented Sep 5, 2015

Check that the http request was success before parsing. This prevents parsing error pages.
@jeroen jeroen Check http responses status before proceeding.

All checks have failed

2 failing checks
continuous-integration/appveyor — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
7e8444a

@gaborcsardi gaborcsardi added a commit that referenced this pull request Sep 5, 2015

@gaborcsardi gaborcsardi Merge pull request #11 from jeroenooms/master 
Check http responses status before proceeding.
 93472ec

@gaborcsardi gaborcsardi merged commit 93472ec into metacran:master Sep 5, 2015
0 of 2 checks passed

0 of 2 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gaborcsardi
Owner

gaborcsardi commented Sep 5, 2015

Thanks! Btw. there is sg wrong with the server I think, because sometimes it returns 502. That's why the CI build fails I think.
@jeroen
Member

jeroen commented Sep 5, 2015

Yes it gives some json parsing errors on cran that is why I fixed it :)
@gaborcsardi
Owner

gaborcsardi commented Sep 5, 2015

OK, a process went haywire on the server and ate up all the free space. It should all be good now. Thanks again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment