Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set record IDs in ObjectToLiteral #353

Closed
fsteeg opened this issue Jan 19, 2021 · 1 comment
Closed

Add option to set record IDs in ObjectToLiteral #353

fsteeg opened this issue Jan 19, 2021 · 1 comment
Assignees
@fsteeg
Projects
Metafacture alt

Comments

@fsteeg
Copy link
Member

fsteeg commented Jan 19, 2021

Like JsonDecoder (see JsonDecoder#decode), ObjectToLiteral should use a counter to set record IDs. For compatibility, default should remain empty strings as IDs (see ObjectToLiteral#process).

Came up in OERSI, where we want to avoid JSON roundtripping for getting record IDs (see Flux).
@fsteeg fsteeg self-assigned this Jan 19, 2021
@fsteeg fsteeg added this to Working in Metafacture alt Jan 19, 2021
fsteeg added a commit that referenced this issue Jan 19, 2021
@fsteeg
Add option to set record IDs in ObjectToLiteral
876be2e 
See #353
@fsteeg fsteeg mentioned this issue Jan 19, 2021
Merged
tibdevelopment pushed a commit to TIBHannover/oersi-etl that referenced this issue Jan 19, 2021
@fsteeg
Use new option to set record IDs in object-to-literal
fb559fb 
See:

https://gitlab.com/oersi/oersi-etl/-/issues/27
metafacture/metafacture-core#353
@fsteeg
Copy link
Member Author

fsteeg commented Jan 19, 2021

Resolved with #354, see usage in https://gitlab.com/oersi/oersi-etl/-/blob/fb559fbb7e3fdcdc4977ab7ba23303844271e509/data/production/hoou-to-oersi.flux#L14

@fsteeg fsteeg closed this as completed Jan 19, 2021
Metafacture alt automation moved this from Working to Done Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsteeg fsteeg

Labels
None yet
Projects
No open projects
Metafacture alt
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsteeg