Switch to PercentEscaper #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr0i
force-pushed
the
metafacture-fix-273-addPercentEncodeToUrlEncode
branch
from
8d82530 to
2292f6c
Compare
This enables both: whitespace converted to a plus sign "+" (which is the default to be backwards compatible) and whitespace escaped as percent "%20". - add guava dependency (uses the same version as metafacture-fix) - introduce test - add to schemata
dr0i
force-pushed
the
metafacture-fix-273-addPercentEncodeToUrlEncode
branch
from
2292f6c to
c093da1
Compare
blackwinter
requested changes
Jun 13, 2023
blackwinter
approved these changes
Jun 13, 2023
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables both:
whitespace converted to a plus sign "+" (which is the default to be backwards compatible) and whitespace escaped as percent "%20".
This shall be the base to solve metafacture-fix#273 . See the discussion at the corresponding PR metafacture/metafacture-fix#285 .