Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: track changes for oersi-etl #16

Closed
wants to merge 1 commit into from
Closed

WIP: track changes for oersi-etl #16

wants to merge 1 commit into from

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Jul 17, 2020

This is a WIP-PR to track the changes in metafacture-fix used in oersi-etl: https://gitlab.com/oersi/oersi-etl

Sample using these Fix features: https://gitlab.com/oersi/oersi-etl/-/blob/develop/data/to-oersibackend/oernds-to-oersi.flux

For merging these, it might make sense to cherry-pick into new, individual PRs for specific issues (like #5).

@blackwinter
Copy link
Member

Can the first commit (683c247) be merged? Either before #60 is merged or right after. I think it would be valuable to have a stable identifier going forward.

@fsteeg
Copy link
Member Author

fsteeg commented Nov 9, 2021

Can the first commit (683c247) be merged? Either before #60 is merged or right after. I think it would be valuable to have a stable identifier going forward.

Right, thanks, good catch, that was the plan, but I forgot. Added to 35-metafix in 1fe336b.

Base automatically changed from 35-metafix to master November 9, 2021 09:38
@blackwinter
Copy link
Member

BTW (in the context of 683c247): Is there a reason why we don't just rename the subproject directories, mimicking the layout in metafacture-core?

  • org.metafacture.fix/ -> metafix/ (no need to override the project name anymore)
  • org.metafacture.fix.ide/ -> metafix-ide/
  • org.metafacture.fix.vsc/ -> metafix-vsc/
  • org.metafacture.fix.web/ -> metafix-web/

@fsteeg
Copy link
Member Author

fsteeg commented Nov 12, 2021

BTW (in the context of 683c247): Is there a reason why we don't just rename the subproject directories, mimicking the layout in metafacture-core?

Sounds good. The current naming is the Xtext/Eclipse convention, but it should work to set up MWE workflow etc. for the simpler directories/names.

@fsteeg fsteeg changed the base branch from master to 102-path April 7, 2022 08:36
Base automatically changed from 102-path to master April 8, 2022 14:54
@fsteeg fsteeg closed this Apr 28, 2022
@fsteeg fsteeg deleted the oersi branch April 28, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants