Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifies that new version is available even though it's the same #125

Closed
metafates opened this issue Nov 1, 2022 · 0 comments · Fixed by #128
Closed

Notifies that new version is available even though it's the same #125

metafates opened this issue Nov 1, 2022 · 0 comments · Fixed by #128
Labels
bug Something isn't working

Comments

@metafates
Copy link
Owner

metafates commented Nov 1, 2022 •
edited
Loading

Describe the bug

There's this silly bug that will notify about "new" version even though they are the same

Screenshot 2022-11-01 at 15 34 32

Reproduction steps

  1. Run mangal help or mangal version

Expected behavior

Same versions should remain the same lol

Additional context

it should be comp <= 0 instead

mangal/version/notify.go

Line 18 in ff4e033

if err == nil && comp == -1 {

@metafates metafates added the bug Something isn't working label Nov 1, 2022
metafates added a commit that referenced this issue Nov 1, 2022
@metafates
fix(version): do not notify for same version #125
9e5d56c
@metafates metafates mentioned this issue Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v4.0.1 metafates/mangal
1 participant
@metafates