Update Wordpress.org Infinite-Scroll plugin with Github version of the plugin #251

Closed
samcleaver opened this Issue Nov 4, 2012 · 21 comments

Comments

5 participants
@samcleaver
Contributor

samcleaver commented Nov 4, 2012

At the moment the version of the Infinite-Scroll on Wordpress.org is still the old version (before Ben's rewrite).

The reason for the Repo version not being on Wordpress.org is because its a huge change (rewrite). There are still a couple of areas where features/options are available in the Wordpress.org version but not in the Repo version. This would normally be fine as users can be notified before they update, but because commits to Wordpress.org SVN are automatically pushed out to all users (and they can only given update information after the update) it means we really have to ensure that everything is consistent before making the leap and updating everyone to the full rewrite.

I'll try and compile a list of features this week, if anyone else can take a look that'd be good as well. The idea being to load up the Wordpress.org plugin, then update it to the Repo version to make sure that theres nothing missing feature wise (and to make sure that the update goes smoothly). My main area of concern at the moment is the callback functionality.

@benbalter

This comment has been minimized.

Show comment Hide comment
@benbalter

benbalter Nov 13, 2012

Contributor

Pinged @67726e in #180, but glad to help out.

Also, FWIW, you can put notices in both the changelog and upgrade notice section, both of which should be visible prior to upgrade.

Contributor

benbalter commented Nov 13, 2012

Pinged @67726e in #180, but glad to help out.

Also, FWIW, you can put notices in both the changelog and upgrade notice section, both of which should be visible prior to upgrade.

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Nov 13, 2012

Contributor

@benbalter I plan on tackling the WordPress plugin in next week or so. I looked at paulirish#175 over the weekend but didn't have time do to anything of consequence with it. It does look like the current WordPress plugin doesn't have any input for the callback option though, so I need to take care of that as well before I can knock out #175.

I'm not sure if anything else is needed aside from the callback. Definitely need to test the hell out of the plugin as well.

Also, anyone know who manges the WordPress SVN repo?

Contributor

67726e commented Nov 13, 2012

@benbalter I plan on tackling the WordPress plugin in next week or so. I looked at paulirish#175 over the weekend but didn't have time do to anything of consequence with it. It does look like the current WordPress plugin doesn't have any input for the callback option though, so I need to take care of that as well before I can knock out #175.

I'm not sure if anything else is needed aside from the callback. Definitely need to test the hell out of the plugin as well.

Also, anyone know who manges the WordPress SVN repo?

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Nov 13, 2012

Contributor

@67726e Myself, Paul and a couple of other people who made commits in the past have access to the Wordpress SVN. It's a pretty bad system for actual development on imo. As soon as you make any changes to the trunk, its pushed out to all Wordpress users. (Revision log: http://plugins.trac.wordpress.org/log/infinite-scroll/)
If you need commit/admin access, just let me know your Wordpress username and I'll add you to the list.

Contributor

samcleaver commented Nov 13, 2012

@67726e Myself, Paul and a couple of other people who made commits in the past have access to the Wordpress SVN. It's a pretty bad system for actual development on imo. As soon as you make any changes to the trunk, its pushed out to all Wordpress users. (Revision log: http://plugins.trac.wordpress.org/log/infinite-scroll/)
If you need commit/admin access, just let me know your Wordpress username and I'll add you to the list.

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Nov 13, 2012

Contributor

I've just done a quick run through (installed old version -> manually upgraded to new version). I think we're missing the following features:

  • Javascript Callbacks (A lot of users use this)
  • Debug switch (really helpful in debugging user issues)
  • Behavior switching (Automatic / Manual)
  • Loading image alignment (this was originally put in as a convenience feature for the user so they didn't have to modify stylesheets, not a show stopper)
  • Variable plugin states (On, Off, On for admins only etc). Again, not a show stopper but meant people could test run the plugin before going live.

At the moment the presets list is set to @benbalter's repo, this presented a problem on my local setup as I don't have openssl installed so it meant the script couldn't access the list. (Github forces https).
It's probably up for debate whether https is beneficial for this list (to stop any MiM attacks) but obviously any users without openssl installed won't be able to use the presets database.

Contributor

samcleaver commented Nov 13, 2012

I've just done a quick run through (installed old version -> manually upgraded to new version). I think we're missing the following features:

  • Javascript Callbacks (A lot of users use this)
  • Debug switch (really helpful in debugging user issues)
  • Behavior switching (Automatic / Manual)
  • Loading image alignment (this was originally put in as a convenience feature for the user so they didn't have to modify stylesheets, not a show stopper)
  • Variable plugin states (On, Off, On for admins only etc). Again, not a show stopper but meant people could test run the plugin before going live.

At the moment the presets list is set to @benbalter's repo, this presented a problem on my local setup as I don't have openssl installed so it meant the script couldn't access the list. (Github forces https).
It's probably up for debate whether https is beneficial for this list (to stop any MiM attacks) but obviously any users without openssl installed won't be able to use the presets database.

@benbalter

This comment has been minimized.

Show comment Hide comment
@benbalter

benbalter Nov 13, 2012

Contributor

Sounds good. Debug should be tied to WP_DEBUG I believe.

As for the others, just need to add to options array, either as UI or as
filter, and should be passed to front end.
On Nov 13, 2012 11:51 AM, "Sam Cleaver" notifications@github.com wrote:

I've just done a quick run through (installed old version -> manually
upgraded to new version). I think we're missing the following features:

  • Javascript Callbacks (A lot of users use this)
  • Debug switch (really helpful in debugging user issues)
  • Behavior switching (Automatic / Manual)
  • Loading image alignment (this was originally put in as a convenience
    feature for the user so they didn't have to modify stylesheets, not a show
    stopper)

At the moment the presets list is set to @benbalterhttps://github.com/benbalter's
repo, this presented a problem on my local setup as I don't have openssl
installed so it meant the script couldn't access the list. (Github forces
https).
It's probably up for debate whether https is beneficial for this list (to
stop any MiM attacks) but obviously any users without openssl installed
won't be able to use the presets database.


Reply to this email directly or view it on GitHubhttps://github.com/paulirish/infinite-scroll/issues/251#issuecomment-10333246.

Contributor

benbalter commented Nov 13, 2012

Sounds good. Debug should be tied to WP_DEBUG I believe.

As for the others, just need to add to options array, either as UI or as
filter, and should be passed to front end.
On Nov 13, 2012 11:51 AM, "Sam Cleaver" notifications@github.com wrote:

I've just done a quick run through (installed old version -> manually
upgraded to new version). I think we're missing the following features:

  • Javascript Callbacks (A lot of users use this)
  • Debug switch (really helpful in debugging user issues)
  • Behavior switching (Automatic / Manual)
  • Loading image alignment (this was originally put in as a convenience
    feature for the user so they didn't have to modify stylesheets, not a show
    stopper)

At the moment the presets list is set to @benbalterhttps://github.com/benbalter's
repo, this presented a problem on my local setup as I don't have openssl
installed so it meant the script couldn't access the list. (Github forces
https).
It's probably up for debate whether https is beneficial for this list (to
stop any MiM attacks) but obviously any users without openssl installed
won't be able to use the presets database.


Reply to this email directly or view it on GitHubhttps://github.com/paulirish/infinite-scroll/issues/251#issuecomment-10333246.

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Dec 5, 2012

Contributor

@beaver6813 I've now gotten the big features put into the WordPress plugin. Tomorrow I will test this as a user upgrading to make sure things work as expected. Assuming they do, are there any objections to deploying?

Also, could you add me to the WordPress plugin developers? My username is Glenn Nelson

Contributor

67726e commented Dec 5, 2012

@beaver6813 I've now gotten the big features put into the WordPress plugin. Tomorrow I will test this as a user upgrading to make sure things work as expected. Assuming they do, are there any objections to deploying?

Also, could you add me to the WordPress plugin developers? My username is Glenn Nelson

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Dec 5, 2012

Contributor

@67726e No objections to deploying at all, I agree that its not an extensible solution for the behaviours but I guess for now its better that we define which behaviors (ones that will work without any extra configuration) they can use.

For the callback, are we passing through the newElements/data parameters? They're quite useful parameters to have, especially when you want to reload JS (such as Facebook like) but only for the new elements.

I've just added you to the Wordpress site, you should have full access to the SVN etc now. Will give the plugin with your changes a whirl now.

Contributor

samcleaver commented Dec 5, 2012

@67726e No objections to deploying at all, I agree that its not an extensible solution for the behaviours but I guess for now its better that we define which behaviors (ones that will work without any extra configuration) they can use.

For the callback, are we passing through the newElements/data parameters? They're quite useful parameters to have, especially when you want to reload JS (such as Facebook like) but only for the new elements.

I've just added you to the Wordpress site, you should have full access to the SVN etc now. Will give the plugin with your changes a whirl now.

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Dec 5, 2012

Contributor

Looks all good from my end, created a pull request which fixes a couple of things in the upgrade from the old plugin to the new. Spotted a compatibility issue with HeadJS (not sure how prevalent its use is) and created #275.
Other than that, looks really good!

Contributor

samcleaver commented Dec 5, 2012

Looks all good from my end, created a pull request which fixes a couple of things in the upgrade from the old plugin to the new. Spotted a compatibility issue with HeadJS (not sure how prevalent its use is) and created #275.
Other than that, looks really good!

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Dec 6, 2012

Contributor

The WordPress plugin's SVN repo now has a tagged version of the 2.5 release and the latest code is now in the trunk.

I have installed the plugin on my test WordPress and everything worked fine.

Contributor

67726e commented Dec 6, 2012

The WordPress plugin's SVN repo now has a tagged version of the 2.5 release and the latest code is now in the trunk.

I have installed the plugin on my test WordPress and everything worked fine.

@DarrenMooney

This comment has been minimized.

Show comment Hide comment
@DarrenMooney

DarrenMooney Dec 6, 2012

I'm sorry to say that 2.5 is not fine on wordpress. I have it on 2 testers. When upgraded, 2.5 reverts to default settings regardless of what has been set by user. There are a couple of tickets up on WP.org about it already.

I'm sorry to say that 2.5 is not fine on wordpress. I have it on 2 testers. When upgraded, 2.5 reverts to default settings regardless of what has been set by user. There are a couple of tickets up on WP.org about it already.

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Dec 6, 2012

Contributor

@DarrenMooney Thanks for the heads up, I'm doing some more testing now to try and reproduce some of these issues. I've found an issue with the loading image but the selectors are all working fine for me. Did it literally revert everything to default when you upgraded?

Contributor

samcleaver commented Dec 6, 2012

@DarrenMooney Thanks for the heads up, I'm doing some more testing now to try and reproduce some of these issues. I've found an issue with the loading image but the selectors are all working fine for me. Did it literally revert everything to default when you upgraded?

@DarrenMooney

This comment has been minimized.

Show comment Hide comment
@DarrenMooney

DarrenMooney Dec 6, 2012

Selectors seemed fine, but callback, loading texts and image, all reverted despite having custom settings. Haven't had a chance to dig that much yet.

Selectors seemed fine, but callback, loading texts and image, all reverted despite having custom settings. Haven't had a chance to dig that much yet.

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Dec 6, 2012

Contributor

Hmm, I've noticed that its adding slashes to any quotes in the loading texts but other than that, it carried over everything for me. Are you using the latest version of Wordpress?

Contributor

samcleaver commented Dec 6, 2012

Hmm, I've noticed that its adding slashes to any quotes in the loading texts but other than that, it carried over everything for me. Are you using the latest version of Wordpress?

@DarrenMooney

This comment has been minimized.

Show comment Hide comment
@DarrenMooney

DarrenMooney Dec 6, 2012

Of course .... my 1st tester is bare vanilla. I will have another look once I get a chance.

Of course .... my 1st tester is bare vanilla. I will have another look once I get a chance.

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Dec 7, 2012

Contributor

@beaver6813 @DarrenMooney The fix version (2.6) has been pushed live.

Contributor

67726e commented Dec 7, 2012

@beaver6813 @DarrenMooney The fix version (2.6) has been pushed live.

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Dec 7, 2012

Contributor

@67726e Looks a lot better, I think we'll have to do some testing around the custom page/post types; quite a few of the people who have raised issues have indicated that they are using custom types. There were lots of issues with the previous plugin version as well (though there was a filter that some could hook onto to force infinite-scroll loading). Most of the issues were/are simply because the theme author codes in a convoluted way that doesn't inform Wordpress what type of page it is.

Contributor

samcleaver commented Dec 7, 2012

@67726e Looks a lot better, I think we'll have to do some testing around the custom page/post types; quite a few of the people who have raised issues have indicated that they are using custom types. There were lots of issues with the previous plugin version as well (though there was a filter that some could hook onto to force infinite-scroll loading). Most of the issues were/are simply because the theme author codes in a convoluted way that doesn't inform Wordpress what type of page it is.

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Dec 7, 2012

Contributor

@beaver6813 Trial by fire. I'm going to look into the custom post as well, although I've never dabbled with them so at least I'll have some fun with it.

Contributor

67726e commented Dec 7, 2012

@beaver6813 Trial by fire. I'm going to look into the custom post as well, although I've never dabbled with them so at least I'll have some fun with it.

@benbalter

This comment has been minimized.

Show comment Hide comment
@benbalter

benbalter Dec 7, 2012

Contributor

Tested on a vanilla install of 3.5, with a custom post type archive. Worked fine.

The plugin fires on all pages unless is_singluar is true (code, which means it should be adding to custom post type archives (as it is).

May make sense to (A) verify that in those that are reporting issues that it is working with non-custom post types (e.g. posts), and (B) that their footer has the standard call to wp_footer() which would prevent the code from loading. Last, to actually check the HTML output. Are there any public facing examples?

Contributor

benbalter commented Dec 7, 2012

Tested on a vanilla install of 3.5, with a custom post type archive. Worked fine.

The plugin fires on all pages unless is_singluar is true (code, which means it should be adding to custom post type archives (as it is).

May make sense to (A) verify that in those that are reporting issues that it is working with non-custom post types (e.g. posts), and (B) that their footer has the standard call to wp_footer() which would prevent the code from loading. Last, to actually check the HTML output. Are there any public facing examples?

@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

This comment has been minimized.

Show comment Hide comment
@67726e

67726e Dec 10, 2012

Contributor

Released 2.6.1

I think the original purpose of this issue has been met, but we seem to have the custom post issue in here as well. Should we turn that into its own issue and close this one?

Contributor

67726e commented Dec 10, 2012

Released 2.6.1

I think the original purpose of this issue has been met, but we seem to have the custom post issue in here as well. Should we turn that into its own issue and close this one?

@samcleaver

This comment has been minimized.

Show comment Hide comment
@samcleaver

samcleaver Feb 20, 2013

Contributor

@67726e Agree, original issue has been addressed, could you spin a new issue so we don't lose track of this (you have a better idea of the issue than I do)? Custom posts aren't a corner case so I suspect a lot of people might be having issues with this.

Contributor

samcleaver commented Feb 20, 2013

@67726e Agree, original issue has been addressed, could you spin a new issue so we don't lose track of this (you have a better idea of the issue than I do)? Custom posts aren't a corner case so I suspect a lot of people might be having issues with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment