New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ontransitionend handler on all properties that will transition when an item is hidden. #28

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@danofames

danofames commented Dec 1, 2014

That the hiddenStyle option needs a declaration that actually hides the card is more obvious in hindsight, but it was unexpected to me that overriding hiddenStyle led to the items remaining visible after they were filtered by the isotope.filter call.

This change was an approach that fixes that behavior, and seemed to have minimal impact. It is suboptimal that the handler would execute for any properties in hiddenStyle.

The unexpected nature could be solved by a note in documentation.

I could also see removing the onTransitionEnd handler in Item.hide, and leave the hiding of the item up to the hiddenStyle option completely. Part of the confusion is that the items are hidden without any overrides to hiddenStyle. As default behavior, this should occur unless a specific request to prevent the hiding after the transition is done is made.

@desandro

This comment has been minimized.

Show comment
Hide comment
@desandro

desandro Feb 8, 2016

Member

Thank you for this contribution. Item now checks for the property to watch so it can trigger transition end callback in getHideRevealTransitionEndProperty. I've left this PR open for a while in case others were interested. Time to close it up 🍓

Member

desandro commented Feb 8, 2016

Thank you for this contribution. Item now checks for the property to watch so it can trigger transition end callback in getHideRevealTransitionEndProperty. I've left this PR open for a while in case others were interested. Time to close it up 🍓

@desandro desandro closed this Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment