New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading packery with requireJS #20
Comments
Yes, I need to test Packery with Require JS |
Ok, please let us know about the outcome... |
Part of the problem here is that the However, Packery code depends on these libraries via eg @desandro Are you completely against using RequireJS for packery, if you can generate a build (w/ almond) that doesn't require clients to use RequireJS? Alternatively, could you wrap the 4 modules of packery in a UMD wrapper? https://github.com/umdjs/umd/blob/master/amdWeb.js Right now I think the only option for RequireJS users to make this work is to intentionally pollute the global scope or include Packery deps outside of AMD. Or, what I'll likely do, copy and paste packery code into an amd-comatible module. But then I won't be able to incorporate new changes very easily. I will buy an org license if @metafizzy can advise us to success here :) |
Thanks for the response and the project itself, @desandro. Glad to hear support is coming! My project is here and defines an AMD module that gets access to Packery through assumed global scope. I'll watch this thread and update as I can to load via AMD. https://github.com/gobengo/streamhub-packery Would you like any help? Perhaps in migrating any deps that you don't author? |
Just keep watching this tracker. |
Brilliant to hear that AMD support is on the way for such a great library @desandro, thanks! Have you got any sort of update on how far away it might be? Watching this thread with eager anticipation ;) |
Any news about this ? |
Hi, we payed the licence and really need to support AMD through RequireJS. Is there an ETA for this fix? |
Any update on this? |
++ |
+1 - would be so nifty to have |
+1 |
I'm looking for feedback on how to best set up RequireJS dependencies in my components. Help me out! See https://github.com/desandro/requirejs-bower-homework |
Support for RequireJS has been added in v1.1.0. See http://packery.metafizzy.co/appendix.html#requirejs I realize it's a bit of a pain to install with Bower and set up config, but it's for the best! Try it out and report back if you have any trouble. |
update docs Ref metafizzy/packery#20
Good news! 😸 packery.pkgd.js is now being built with RequireJS. This means you can require Currently, the RequireJS optimizer outputs requirejs( [
// require the file
'path/to/packery.pkgd.js',
// require the named module
'packery/js/packery'
// two parameters, packeryPkg is undefined
// Packery is the working module
], function( packeryPkg, Packery ) {
new Packery('#container');
}); One solution is to remove the naming of Please chime in if you have a preference either way. |
Sweet! I'll try it this weekend, thank you. |
Hi Desandro,
I am trying to load packery with requireJS, but I keep getting ,,Uncaught TypeError: Cannot read property 'prototype' of undefined " error message, even if packery is not initialized anywhere on the page. That's 486. row of packery.pkgd.js file.
Any help is appreciated. Thanks...
The text was updated successfully, but these errors were encountered: