Closed
Conversation
…to separate files.
…nside Strophe.Connection.
Contributor
Author
|
Should Strophe still define window globals even if AMD is used? There are a lot of Strophe plugins which expect globals. I've found that using the shim config in require.js is unreliable for Strophe plugins which expect the Strophe global. The amdWebGlobal.js below defines a global even if AMD is being used. https://github.com/umdjs/umd/blob/master/amdWeb.js |
|
A quick message to show my support to the initiative, I hope soon Strophe will be AMD ready. |
Gordin
pushed a commit
to Gordin/strophejs
that referenced
this pull request
Jan 31, 2015
escapeNode & unescapeNode null tolerance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my initial attempt at AMD support for issue #66, with supporting tests. I've made some compromises to make the diff smaller. Ideally, the source files should be renamed to match the module name (ie Base64.js instead of base64.js) so that you don't need the path mapping in requirejs.config. I've also added an example using AMD.
I will squash the commits before merging once getting some feedback.