Confusing behavior on removing `externallyProvisioned: true`

[dtantsur]

I'm not sure we ever intended for the externallyProvisioned field to be reset to false, but right now it explicitly causes inspection to start. Unfortunately, it cannot possibly succeed with the Ironic node in the active state:

action \"inspecting\" failed: hardware inspection failed: unexpected provision state active","errorVerbose":"unexpected provision state active

If inspection is disabled, the next state is preparing, which I suspect will fail the same way for the same reason.

We need to decide on a sane behavior in this case and probably add the scenario to e2e tests.

/kind bug

[dtantsur]

On thinking more about it, I think removing externallyProvisioned should result in a normal provisioned state, which then can be re-inspected or whatever.

[Rozzii]

We have discussed this during community meeting, there are multiple options:
Let's just document this behavior and if someone is interested in the community then feel free to fix this.
/triage accepted
/help

[metal3-io-bot]

@Rozzii:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

Details

In response to this:

We have discussed this during community meeting, there are multiple options:
Let's just document this behavior and if someone is interested in the community then feel free to fix this.
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.