Define vlan interfaces to be included in introspection report

[bfournie]

Define the inspector kernel parameter to include vlan interfaces
and associated IP addresses in the introspection report.

[metal3-io-bot]

Hi @bfournie. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hardys]

Thanks @bfournie - does this depend on a corresponding change to ironic-image or ironic-inspector-image?

[bfournie]

Thanks @bfournie - does this depend on a corresponding change to ironic-image or ironic-inspector-image?

Yes, metal3-io/ironic-image#246

[dhellmann]

How does the VLAN data show up? Are there just more interfaces added to the existing data structure, or do we need to do something to expand the API to hold new data?

[bfournie]

How does the VLAN data show up? Are there just more interfaces added to the existing data structure, or do we need to do something to expand the API to hold new data?

Yes, there are just more interfaces added to the existing structure so no expansion is needed. The vlan interfaces will be named <interface.vlan> e.g. "eth0.100" and will be handled as normal interfaces.

[dhellmann]

How does the VLAN data show up? Are there just more interfaces added to the existing data structure, or do we need to do something to expand the API to hold new data?

Yes, there are just more interfaces added to the existing structure so no expansion is needed. The vlan interfaces will be named <interface.vlan> e.g. "eth0.100" and will be handled as normal interfaces.

Sounds good, thanks.

[stbenjam]

/ok-to-test

[dtantsur]

/approve

The code looks good, but you need to fix markdown (I suspect redundant indentation).

[dtantsur]

Newlines are not rendered in markdown, you need at least commas between the items

[dtantsur]

/test-integration

[hardys]

lgtm but needs a rebase @bfournie

[bfournie]

lgtm but needs a rebase @bfournie

Done

[iurygregory]

/test-integration

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, dtantsur, elfosardo, iurygregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hardys]

/lgtm