This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
✨ Adding clusterctl cluster template #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
maelk
force-pushed
the
v1a3-clusterctl-mael
branch
2 times, most recently
from
06d4b73
to
54efb81
Compare
|
/test-v1a3-integration |
maelk
force-pushed
the
v1a3-clusterctl-mael
branch
from
54efb81
to
f47fb2b
Compare
|
/test-v1a3-integration |
maelk
force-pushed
the
v1a3-clusterctl-mael
branch
from
f47fb2b
to
eb00ec0
Compare
metal3-io-bot
added
size/XL
maelk
force-pushed
the
v1a3-clusterctl-mael
branch
from
eb00ec0
to
b8d126b
Compare
and add clusterctl-settings.json and example variables file modify docs and adjust gitignore
maelk
force-pushed
the
v1a3-clusterctl-mael
branch
from
b8d126b
to
49325d1
Compare
|
/test-v1a3-integration |
|
looks good to me. |
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a cluster template and the needed documentation. It also adds a CACPK example and modifies the makefile to include the proper files in the release.