Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adding support for dns servers in IPAM #120

Merged
merged 1 commit into from
Jul 23, 2020
Merged

✨ Adding support for dns servers in IPAM #120

merged 1 commit into from
Jul 23, 2020

Conversation

maelk
Copy link
Member

@maelk maelk commented Jul 20, 2020

What this PR does / why we need it:

This commit adds support for the newly added dnsServers field in
IPAddress and uplifts the ip-address-manager dependency.

It implements metal3-io/metal3-docs#125 and is based on metal3-io/ip-address-manager#9

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2020
@maelk
Copy link
Member Author

maelk commented Jul 20, 2020

/hold requires metal3-io/ip-address-manager#9 to be merged and the IPAM controller to be released

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@maelk
Copy link
Member Author

maelk commented Jul 20, 2020

/hold cancel
/test-v1a4-integration

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2020
@maelk
Copy link
Member Author

maelk commented Jul 21, 2020

/cc @fmuyassarov
/cc @Jaakko-Os
/cc @Xenwar

furkatgofurov7
furkatgofurov7 reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just small nits
Edit: Sorry, I was reviewing it with adding single comments :)

@maelk
Copy link
Member Author

maelk commented Jul 21, 2020

fixed, thanks
/test-v1a4-integration

Xenwar
Xenwar reviewed Jul 21, 2020
View reviewed changes
api/v1alpha4/metal3datatemplate_types.go Outdated Show resolved Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml Outdated Show resolved Hide resolved
baremetal/metal3data_manager.go Outdated Show resolved Hide resolved
baremetal/metal3data_manager.go Outdated Show resolved Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml Outdated
items:
properties:
key:
description: Key is the metadata key when redendering this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Key is the metadata key"
What is this key used for ? to retrieve the object ?
Mention the purpose.

fmuyassarov
fmuyassarov reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for the above comments to be addressed.

@maelk maelk force-pushed the v1a4-mael branch 2 times, most recently from 566498c to 58f0e62 Compare July 22, 2020 07:03
Jaakko-Os
Jaakko-Os reviewed Jul 22, 2020
View reviewed changes
Copy link
Contributor

@Jaakko-Os Jaakko-Os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@maelk
Copy link
Member Author

maelk commented Jul 22, 2020

/test-v1a4-integration

@fmuyassarov
Copy link
Member

@maelk
Would you mind to rebase and resolve the conflicts please?

@maelk
Copy link
Member Author

maelk commented Jul 22, 2020

done, thank you
/test-v1a4-integration

@maelk
Copy link
Member Author

maelk commented Jul 22, 2020

/retest

@maelk
Adding support for dns servers in IPAM
0ec3e5e 
This commit adds support for the newly added dnsServers field in
IPAddress and uplifts the ip-address-manager dependency
@maelk
Copy link
Member Author

maelk commented Jul 22, 2020

/test-v1a4-integration

fmuyassarov
fmuyassarov reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@metal3-io-bot metal3-io-bot merged commit f43c809 into metal3-io:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenwar Xenwar Xenwar left review comments

@fmuyassarov fmuyassarov fmuyassarov left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@Jaakko-Os Jaakko-Os Jaakko-Os left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maelk @metal3-io-bot @fmuyassarov @Xenwar @furkatgofurov7 @Jaakko-Os