Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adopt to BMO kubebuilder changes #137

Merged
merged 1 commit into from Oct 9, 2020
Merged

✨ Adopt to BMO kubebuilder changes #137

merged 1 commit into from Oct 9, 2020

Conversation

kashifest
Copy link
Member

No description provided.

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2020
@kashifest
Copy link
Member Author

/hold
/test-integration

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
@kashifest kashifest force-pushed the update/bmo-config-kashif branch 2 times, most recently from 8e5ba0b to 03581ba Compare October 8, 2020 12:31
@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration
/test-v1a3-integration
/test-v1a3-centos-integration

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kashifest
Copy link
Member Author

/test-integration

@kashifest
Copy link
Member Author

/test-integration

@maelk
Copy link
Member

maelk commented Oct 9, 2020

This is in deadlock with metal3-dev-env PR. Merging manually

@maelk maelk merged commit 028128e into metal3-io:master Oct 9, 2020
@kashifest kashifest deleted the update/bmo-config-kashif branch June 20, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelk maelk maelk approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kashifest @metal3-io-bot @maelk