Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 getting-started: clean up ironic bits #200

Merged
merged 1 commit into from
May 26, 2021
Merged

📖 getting-started: clean up ironic bits #200

merged 1 commit into from
May 26, 2021

Conversation

dtantsur
Copy link
Member

Explain the deploy ramdisk in a cleaner way.
Use consistent spelling for Ironic (upper case).

@furkatgofurov7
Copy link
Member

Thanks for the patch @dtantsur. Regarding the consistency, we could fix also all other occurrences of 'Ironic' in other documents in the same patch, maybe? Here is the list of docs I found mentioning it (might not be full list though):

@dtantsur
Copy link
Member Author

I don't disagree with that, but I don't have time to go through other documents, unfortunately.

@furkatgofurov7
Copy link
Member

@dtantsur can you please fix the markdown issue? Then, this can go as it is, and making consistent all other occurrences of 'Ironic' in other documents will be tackled in #202.

@fmuyassarov
Copy link
Member

/retest

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2021
@fmuyassarov
Copy link
Member

/test golint

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@kashifest
Copy link
Member

@dtantsur you need to take care of the markdownlint error. Thanks for explaining ramdisk.

Explain the deploy ramdisk in a cleaner way.
Use consistent spelling for Ironic (upper case).
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. labels May 26, 2021
@fmuyassarov
Copy link
Member

/test-integration

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@metal3-io-bot metal3-io-bot merged commit e9a865e into metal3-io:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants