-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 getting-started: clean up ironic bits #200
Conversation
Thanks for the patch @dtantsur. Regarding the consistency, we could fix also all other occurrences of 'Ironic' in other documents in the same patch, maybe? Here is the list of docs I found mentioning it (might not be full list though): |
I don't disagree with that, but I don't have time to go through other documents, unfortunately. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test golint |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dtantsur you need to take care of the |
Explain the deploy ramdisk in a cleaner way. Use consistent spelling for Ironic (upper case).
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Explain the deploy ramdisk in a cleaner way.
Use consistent spelling for Ironic (upper case).