Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix example manifests generation #204

Merged
merged 1 commit into from
May 7, 2021

Conversation

wgslr
Copy link
Member

@wgslr wgslr commented May 6, 2021

What this PR does / why we need it:

  • fixes the examples/generate.sh script to successfully generate example manifests. It also pins the versions of images used in example manifests to avoid breaking compatibility with the manifests.
  • updates ensure-kustomize.sh to use an up-to-date URL for downloading kustomize

This allows generating examples and running make deploy, which is a step in a good direction. There is still an issue with capm3-baremetal-operator-controller-manager not receiving basic auth credentials, which will be addressed in a future PR.

I will squash the commits after review.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2021
@wgslr wgslr changed the title WIP 🌱 Make examples deployable 🌱 Fix example manifests generation May 6, 2021
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2021
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking caring of this.
/test-integration
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, wgslr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@kashifest
Copy link
Member

/test-integration

Copy link
Member

@namnx228 namnx228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. Just a question: Why do we need to have an image version patch instead of directly fix the versions of CAPI components.

@wgslr
Copy link
Member Author

wgslr commented May 6, 2021

Overall, it looks good to me. Just a question: Why do we need to have an image version patch instead of directly fix the versions of CAPI components.

If I understand the situation correctly, moving to the newer versions in the examples would be moving to CAPM3 version v1alpha4. Which is a separate effort, and for now we also want to have working examples with v1alpha3.

I'd also argue that even if a newer version should be used, it still should be pinned to specific tags rather than the master to make the examples reliable and reproducible.

@fmuyassarov
Copy link
Member

@wgslr This looks good. Can you please squash the commits before we merge the PR?

Fixes issues that prevented generation and deployment of example
manifests.
@wgslr
Copy link
Member Author

wgslr commented May 7, 2021

@fmuyassarov done

@fmuyassarov
Copy link
Member

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@metal3-io-bot metal3-io-bot merged commit b516aea into metal3-io:master May 7, 2021
@wgslr wgslr deleted the update/examples-wgslr branch May 20, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants