-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix example manifests generation #204
Conversation
e81226f
to
8fb0c68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking caring of this.
/test-integration
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, wgslr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it looks good to me. Just a question: Why do we need to have an image version patch instead of directly fix the versions of CAPI components.
If I understand the situation correctly, moving to the newer versions in the examples would be moving to CAPM3 version v1alpha4. Which is a separate effort, and for now we also want to have working examples with v1alpha3. I'd also argue that even if a newer version should be used, it still should be pinned to specific tags rather than the master to make the examples reliable and reproducible. |
@wgslr This looks good. Can you please squash the commits before we merge the PR? |
Fixes issues that prevented generation and deployment of example manifests.
8fb0c68
to
b2170b7
Compare
@fmuyassarov done |
/test-integration |
What this PR does / why we need it:
examples/generate.sh
script to successfully generate example manifests. It also pins the versions of images used in example manifests to avoid breaking compatibility with the manifests.ensure-kustomize.sh
to use an up-to-date URL for downloading kustomizeThis allows generating examples and running
make deploy
, which is a step in a good direction. There is still an issue withcapm3-baremetal-operator-controller-manager
not receiving basic auth credentials, which will be addressed in a future PR.I will squash the commits after review.