Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Metal3MachineTemplate log output #269

Merged
merged 1 commit into from
Sep 2, 2021
Merged

🐛 Fix Metal3MachineTemplate log output #269

merged 1 commit into from
Sep 2, 2021

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

seeing this in the log:

I0817 06:27:09.282274       1 metal3machinetemplate_manager.go:96] controllers/Metal3MachineTemplate/Metal3MachineTemplate-controller "msg"="Synchronized automatedCleaningMode field value between Metal3MachineTemplate %v/%v and Metal3MachineMachine %v/%v" "metal3-machine-template"={"Namespace":"metal3","Name":"test1-workers"} "metal3"="test1-workers-4wtsr"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2021
@metal3-io-bot
Copy link
Contributor

Hi @jichenjc. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2021
@furkatgofurov7
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2021
furkatgofurov7
furkatgofurov7 reviewed Aug 23, 2021
View reviewed changes
baremetal/metal3machinetemplate_manager.go Outdated
@@ -93,7 +94,7 @@ func (m *MachineTemplateManager) UpdateAutomatedCleaningMode(ctx context.Context
return errors.Wrapf(err, "failed to update metal3Machine: %s", m3m.Name)
}
if m3m.Spec.AutomatedCleaningMode == m.Metal3MachineTemplate.Spec.Template.Spec.AutomatedCleaningMode {
m.Log.Info("Synchronized automatedCleaningMode field value between Metal3MachineTemplate %v/%v and Metal3MachineMachine %v/%v", m.Metal3MachineTemplate.Namespace, m.Metal3MachineTemplate.Name, m3m.Namespace, m3m.Name)
m.Log.Info("Synchronized automatedCleaningMode field value between ", "Metal3MachineTemplate", fmt.Sprintf("%v/%v", m.Metal3MachineTemplate.Namespace, m.Metal3MachineTemplate.Name), "Metal3MachineTemplate", fmt.Sprintf("%v/%v", m3m.Namespace, m3m.Name))
Copy link
Member

@furkatgofurov7 furkatgofurov7 Aug 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

Suggested change
m.Log.Info("Synchronized automatedCleaningMode field value between ", "Metal3MachineTemplate", fmt.Sprintf("%v/%v", m.Metal3MachineTemplate.Namespace, m.Metal3MachineTemplate.Name), "Metal3MachineTemplate", fmt.Sprintf("%v/%v", m3m.Namespace, m3m.Name))
m.Log.Info("Synchronized automatedCleaningMode field value between ", "Metal3MachineTemplate", fmt.Sprintf("%v/%v", m.Metal3MachineTemplate.Namespace, m.Metal3MachineTemplate.Name), "Metal3Machine", fmt.Sprintf("%v/%v", m3m.Namespace, m3m.Name))

?

@furkatgofurov7
Copy link
Member

@jichenjc can you please address the above comment, before we run the integration tests? Thanks!

@furkatgofurov7
Copy link
Member

/retitle 🐛 Fix Metal3MachineTemplate log output

@metal3-io-bot metal3-io-bot changed the title Update logs 🐛 Fix Metal3MachineTemplate log output Aug 31, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 1, 2021

my bad ... just updated, thanks for reminder

@furkatgofurov7
Copy link
Member

/test-integration
/approve
/cc @kashifest

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 2, 2021

/test-integration

@jichenjc
Copy link
Contributor Author

jichenjc commented Sep 2, 2021

/retest

@furkatgofurov7
Copy link
Member

/test-integration

@furkatgofurov7
Copy link
Member

/cc @fmuyassarov

fmuyassarov
fmuyassarov reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and fix!
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@metal3-io-bot metal3-io-bot merged commit aebe2ad into metal3-io:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jichenjc @metal3-io-bot @furkatgofurov7 @fmuyassarov