Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP testing with CentOS8 #157

Closed
wants to merge 2 commits into from
Closed

WIP testing with CentOS8 #157

wants to merge 2 commits into from

Conversation

@hardys
Copy link
Member

hardys commented Dec 17, 2019

This aims to remove the RDO repo dependency for both RHEL8 and CentOS8 - the packages we need from there have reduced since e.g vbmc is now containerized and the qemu-kvm changes needed are in the main el8 repos now.

The main TODO item is how we handle install of openstackclient but for now this is handled via pip, similar to what is already done on Ubuntu.

Marking this WIP as I've only tested on RHEL8 so far, @yrobla is planning to try with CentOS and provide feedback on any additional fixes needed.

This may also enable testing on CentOS8 where the RDO repos installed
for CentOS8 do not yet exist.

The dependencies on the RDO repos were virtualbmc (now containerized)
newer qemu-kvm (now in RHEL/CentOS8) and ironicclient/openstackclient.

The remaining client dependency is moved to pip for now, but we should
probably look at running that from a container image instead.
@metal3-io-bot

This comment has been minimized.

Copy link
Collaborator

metal3-io-bot commented Dec 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yrobla yrobla force-pushed the hardys:centos8 branch 2 times, most recently from 6e140b7 to 4a42835 Dec 17, 2019
@yrobla yrobla force-pushed the hardys:centos8 branch from 4a42835 to 6fa8da7 Dec 18, 2019
@metal3-io-bot

This comment has been minimized.

Copy link
Collaborator

metal3-io-bot commented Dec 18, 2019

@hardys: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
shellcheck 6fa8da7 link /test shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

elfosardo left a comment

are we missing the centos8 part in vm-setup/roles/packages_installation/tasks/main.yml ?

sudo dnf -y --repofrompath="current-tripleo,https://trunk.rdoproject.org/${DISTRO}-master/current-tripleo" install "python*-tripleo-repos" --nogpgcheck
sudo tripleo-repos current-tripleo
# There are some packages which are newer in the tripleo repos
sudo yum -y update

This comment has been minimized.

Copy link
@elfosardo

elfosardo Jan 14, 2020

Contributor

let's use dnf here

@hardys

This comment has been minimized.

Copy link
Member Author

hardys commented Jan 20, 2020

are we missing the centos8 part in vm-setup/roles/packages_installation/tasks/main.yml ?

Yes good point, I thought @yrobla already pushed a fix for that but it looks like we are missing that, I'll rebase and update, thanks!

@hardys hardys mentioned this pull request Jan 21, 2020
@hardys

This comment has been minimized.

Copy link
Member Author

hardys commented Feb 14, 2020

Replaced by #223

@hardys hardys closed this Feb 14, 2020
derekhiggins pushed a commit to derekhiggins/dev-scripts that referenced this pull request Mar 4, 2020
Centos 8 behaves in a similar way as RHEL 8. So we
need to add the check for Centos 8 and include it on
the needed conditionals.

Signed-off-by: Yolanda Robla <yroblamo@redhat.com>
Depends-on: metal3-io/metal3-dev-env#157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.