Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Fix ironic installation with kustomize instruction #407

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 2, 2024

Fix #298

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2024
@mquhuy mquhuy force-pushed the mquhuy/fix-ironic-installation-with-kustomize-instruction branch from fee6a88 to efada29 Compare April 2, 2024 14:12
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but the lines are very long.
I guess we don't enforce any line length here yet @tuminoid ?
Could you anyway perhaps wrap the lines so it is easier to read the "code" @mquhuy ?

@mquhuy mquhuy force-pushed the mquhuy/fix-ironic-installation-with-kustomize-instruction branch from efada29 to c3869b7 Compare April 4, 2024 04:32
@mquhuy
Copy link
Member Author

mquhuy commented Apr 4, 2024

The content looks good, but the lines are very long. I guess we don't enforce any line length here yet @tuminoid ? Could you anyway perhaps wrap the lines so it is easier to read the "code" @mquhuy ?

Thanks @lentzi90. I've updated it.

@mquhuy mquhuy force-pushed the mquhuy/fix-ironic-installation-with-kustomize-instruction branch 3 times, most recently from d53a824 to 49c15b0 Compare April 4, 2024 06:38
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2024
@mquhuy mquhuy force-pushed the mquhuy/fix-ironic-installation-with-kustomize-instruction branch from 49c15b0 to 270ce40 Compare April 4, 2024 06:40
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/fix-ironic-installation-with-kustomize-instruction branch from 270ce40 to 76a928a Compare April 4, 2024 06:41
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Apr 4, 2024

The content looks good, but the lines are very long. I guess we don't enforce any line length here yet @tuminoid ? Could you anyway perhaps wrap the lines so it is easier to read the "code" @mquhuy ?

This repo has so much old documentation that I did not enforce it yet, need to fix a lot of docs for that. One day, one beautiful day it'll be done 😄

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@metal3-io-bot metal3-io-bot merged commit 4077447 into metal3-io:main Apr 4, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/fix-ironic-installation-with-kustomize-instruction branch April 4, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-guide: Update/fix Ironic installation guide
4 participants