Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies from mirrord-layer #220

Closed
3 tasks
Tracked by #98
abhirag opened this issue Jul 28, 2022 · 3 comments
Closed
3 tasks
Tracked by #98

Remove unused dependencies from mirrord-layer #220

abhirag opened this issue Jul 28, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@abhirag
Copy link

abhirag commented Jul 28, 2022

mirrord-layer has the following unused dependencies --

mirrord-layer v2.5.0 (/home/parallels/Documents/mirrord_build_time/mirrord/mirrord-layer)
└─── dependencies
     ├─── "clap"
     ├─── "multi-map"
     ├─── "nanoid"
     ├─── "nix"
     └─── "queues"
  • Verify the analysis using cargo-udeps
  • Remove the dependencies from Cargo.toml
  • Make sure that the build succeeds
@abhirag abhirag added the enhancement New feature or request label Jul 28, 2022
@aviramha aviramha mentioned this issue Jul 28, 2022
4 tasks
@eyalb181 eyalb181 added the good first issue Good for newcomers label Aug 10, 2022
@thumbpr
Copy link
Contributor

thumbpr commented Aug 11, 2022

Hi I am beginner and it looks like this issue is for me! :D

@eyalb181
Copy link
Member

@neimsaci All yours! I've assigned you the issue, if you need any help feel free to ask here or on Discord. Thanks!

@aviramha
Copy link
Member

oops. We forgot to close this! Fixed in #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants