{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":557261545,"defaultBranch":"master","name":"tracing","ownerLogin":"metalbear-co","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-10-25T11:20:08.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/99899594?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1712317566.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"269f75d6d0d87ebd195155c3361afcd154529ff5","ref":"refs/heads/conditional_instrument","pushedAt":"2024-04-05T11:46:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aviramha","name":"Aviram Hassan","path":"/aviramha","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/41201924?s=80&v=4"},"commit":{"message":"compile instrument only when not release","shortMessageHtmlLink":"compile instrument only when not release"}},{"before":"196e83e1f3d6d55fa55a5b82e7d36104d56ab4fd","after":"908cc432a5994f6e17c8f36e13c217dc40085704","ref":"refs/heads/master","pushedAt":"2024-04-05T11:13:10.000Z","pushType":"push","commitsCount":98,"pusher":{"login":"aviramha","name":"Aviram Hassan","path":"/aviramha","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/41201924?s=80&v=4"},"commit":{"message":"tracing: fix event macros with constant field names in the first position (#2883)\n\n\r\n## Motivation\r\n\r\nConst argumetns in `level!` macros do not work when in the first\r\nposition.\r\n\r\nThis also seems to have fixed #2748 where literals for fields names like\r\n`info!(\"foo\" = 2)` could not be used outside the `event!` macro.\r\n\r\n\r\nFixes #2837\r\nFixes #2738\r\n\r\n## Solution\r\n\r\nPrevisously, `level!($(args:tt))` was forwarded to `event!(target: ...,\r\nlevel: ..., { $(args:tt) })` but the added curly braces seem to have\r\nprevented the `event` macro from correctly understanding the arguments\r\nand it tried to pass them to `format!`.\r\n\r\nWith this change there may have some performance impact when expanding\r\nthe macros in most cases where the braces could have been added as it\r\nwill take one more step.\r\n\r\nThese are the two relevant `event!` blocks I believe, the new tests used\r\nto expand to the first one (with empty fields), now they expand to the\r\nlatter:\r\n```\r\n    (target: $target:expr, $lvl:expr, { $($fields:tt)* }, $($arg:tt)+ ) => (\r\n        $crate::event!(\r\n            target: $target,\r\n            $lvl,\r\n            { message = $crate::__macro_support::format_args!($($arg)+), $($fields)* }\r\n        )\r\n    );\r\n    (target: $target:expr, $lvl:expr, $($arg:tt)+ ) => (\r\n        $crate::event!(target: $target, $lvl, { $($arg)+ })\r\n    );\r\n```","shortMessageHtmlLink":"tracing: fix event macros with constant field names in the first posi…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEKMzeugA","startCursor":null,"endCursor":null}},"title":"Activity · metalbear-co/tracing"}