Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.10.0 manifests point to main tag instead of release tag #874

Closed
SriRamanujam opened this issue Jun 8, 2021 · 2 comments · Fixed by #876
Closed

v0.10.0 manifests point to main tag instead of release tag #874

SriRamanujam opened this issue Jun 8, 2021 · 2 comments · Fixed by #876
Labels
bug

Comments

@SriRamanujam
Copy link

I noticed that the v0.10.0 manifests' images are pointing at the main tag instead of the v0.10.0 tag. Is this expected? Previously, manifests for a tagged release would always point at the tagged image corresponding to that release.
@russellb
Copy link
Collaborator

russellb commented Jun 8, 2021

Thanks. This is supposed to be automated, but the automation broke because the regex in the script doesn't match anymore. It used to match image: metallb/controller, but since moving from docker hub to quay.io, it needs to match image: quay.io/metallb/controller, for example.

@johananl FYI

@russellb
Copy link
Collaborator

russellb commented Jun 8, 2021

The good news is that main matches v0.10.0 for now. We'll definitely get this fixed before merging anything risky into main.

russellb added a commit to russellb/metallb that referenced this issue Jun 8, 2021
@russellb
release: Fix image reference regex
438888a 
The release process script has a regex for fixing image references in
manifests, but these were not updated to reflect the move to quay.io.
This change updates it so the image reference will properly get updated
on the next release.

Fixes metallb#874
@russellb russellb mentioned this issue Jun 8, 2021
Merged
@russellb russellb added the bug label Jun 9, 2021
russellb added a commit that referenced this issue Jun 9, 2021
@russellb
release: Fix image reference regex
ee5051f 
The release process script has a regex for fixing image references in
manifests, but these were not updated to reflect the move to quay.io.
This change updates it so the image reference will properly get updated
on the next release.

Fixes #874
russellb added a commit that referenced this issue Jun 9, 2021
@russellb
release: Fix image reference regex
e811ed6 
The release process script has a regex for fixing image references in
manifests, but these were not updated to reflect the move to quay.io.
This change updates it so the image reference will properly get updated
on the next release.

Fixes #874

(cherry picked from commit ee5051f)
rata pushed a commit to kinvolk/metallb that referenced this issue Feb 17, 2022
@russellb @rata
release: Fix image reference regex
ab1f4ef 
The release process script has a regex for fixing image references in
manifests, but these were not updated to reflect the move to quay.io.
This change updates it so the image reference will properly get updated
on the next release.

Fixes metallb#874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: Fix image reference regex russellb/metallb
2 participants
@russellb @SriRamanujam