Controller: fix panic in convergeBalancer#1168
Merged
fedepaol merged 1 commit intometallb:mainfrom Jan 17, 2022
Merged
Conversation
The controller can panic if a user updated a service by specifying
a different IP than the one currently assigned and changing another
field that causes the controller to clear the service's state.
For example, updating the address pool of a service and specifying
spec.loadBalancerIP from the new address pool results in:
```
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
main.(*controller).convergeBalancer(0xc0001205a0, {0x15cf500, 0xc0001bbc20}, {0xc0002b8730, 0xf}, 0xc000132c80)
/home/obraunsh/projects/metallb/controller/service.go:119 +0x2306
```
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
oribon
requested review from
fedepaol,
johananl,
rata and
russellb
as code owners
fedepaol
reviewed
Jan 17, 2022
| return true | ||
| } | ||
| if svc.Spec.LoadBalancerIP != lbIPs[0].String() { | ||
| if len(lbIPs) != 0 && svc.Spec.LoadBalancerIP != lbIPs[0].String() { |
Member
There was a problem hiding this comment.
I'd be on the paranoid side and clear also if len(lbIPs) == 0 && svc.Spec.LoadBalancerIP != ""
Member
Author
There was a problem hiding this comment.
len(lbIPs) == 0 at this point could only happen if the state was already cleared, should I still add it?
Member
There was a problem hiding this comment.
Either in that scenario, or if the service comes in without ips assigned. Again, I would say that it's not necessary, but I prefer being on the paranoid side.
Member
There was a problem hiding this comment.
Nevermind, I just noticed we are inside a if len(lbIPs) != 0 {
Member
|
LGTM |
fedepaol
pushed a commit
to fedepaol/metallb
that referenced
this pull request
Jan 24, 2022
The controller can panic if a user updated a service by specifying
a different IP than the one currently assigned and changing another
field that causes the controller to clear the service's state.
For example, updating the address pool of a service and specifying
spec.loadBalancerIP from the new address pool results in:
```
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
main.(*controller).convergeBalancer(0xc0001205a0, {0x15cf500, 0xc0001bbc20}, {0xc0002b8730, 0xf}, 0xc000132c80)
/home/obraunsh/projects/metallb/controller/service.go:119 +0x2306
```
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
fedepaol
pushed a commit
to fedepaol/metallb
that referenced
this pull request
Jan 25, 2022
The controller can panic if a user updated a service by specifying
a different IP than the one currently assigned and changing another
field that causes the controller to clear the service's state.
For example, updating the address pool of a service and specifying
spec.loadBalancerIP from the new address pool results in:
```
panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
main.(*controller).convergeBalancer(0xc0001205a0, {0x15cf500, 0xc0001bbc20}, {0xc0002b8730, 0xf}, 0xc000132c80)
/home/obraunsh/projects/metallb/controller/service.go:119 +0x2306
```
Signed-off-by: Ori Braunshtein <obraunsh@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The controller can panic if a user updated a service by specifying
a different IP than the one currently assigned and changing another
field that causes the controller to clear the service's state.
For example, updating the address pool of a service and specifying
spec.loadBalancerIP from the new address pool results in:
Signed-off-by: Ori Braunshtein obraunsh@redhat.com