Set BGP origin code into igp#1242
Merged
Merged
Conversation
Currently BGP origin code for external service routes advertised by metallb is set to `incomplete` which is incorrect. Hence setting this value to `igp` by default which seems to be appropriate origin code for service routes. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
requested review from
fedepaol,
johananl,
rata and
russellb
as code owners
Contributor
Author
|
/cc @msherif1234 |
Member
|
Is this something we can extend the current tests to validate it? |
This validates BGP origin code is set to `igp` for the service routes advertised by MetalLB. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Contributor
Author
yes @fedepaol , added a validation to check bgp origin now. |
Member
|
LGTM |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently BGP origin code for external IP routes advertised
by metallb is set to
incompletewhich is incorrect.Hence setting this value to
igpby default which seems to beappropriate origin code for service routes.
Fixes #1217
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com