Add updateStrategy for controller and speaker #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
requested review from
fedepaol,
johananl,
rata and
russellb
as code owners
farodin91
force-pushed
the
updateStrategy
branch
2 times, most recently
from
60d951b to
c80e45e
Compare
gclawes
reviewed
May 14, 2022
charts/metallb/README.md
Outdated
| # metallb | ||
|
|
||
|    | ||
|    |
Contributor
Member
There was a problem hiding this comment.
Yeah automating and enforcing would be great.
We are doing it already for a bunch of other resources, CI won't allow the PR in if the content is not aligned.
Member
|
@farodin91 mind rebasing? We now have automatic readme generation / enforcing. |
Contributor
Author
|
@fedepaol I have rebased some time ago. |
Member
I still see a conflict though, can you fix it? Thanks! |
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91
force-pushed
the
updateStrategy
branch
from
743a0df to
83c4d5a
Compare
Contributor
Author
|
@fedepaol Updated. |
Member
|
LGTM, thanks |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.