Filter out no IP interfaces for L2 advertisement #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pperiyasamy
requested review from
fedepaol,
johananl,
rata and
russellb
as code owners
fedepaol
reviewed
Apr 28, 2022
| } | ||
| if ipaddr.IP.To4() != nil || !ipaddr.IP.IsLinkLocalUnicast() { | ||
| continue | ||
| if ipaddr.IP.To4() != nil && (ifi.Flags&net.FlagBroadcast) != 0 { |
Member
There was a problem hiding this comment.
Would it just check len (addrs) be enough to skip the interface?
Member
There was a problem hiding this comment.
Never mind, checked offline. This is better as it takes into account the case where an interface is v4 or v6 only.
Member
|
Code aside, we need to understand if this is always the behaviour we want, or if we are cutting out corner case that are still working. |
fedepaol
reviewed
Apr 28, 2022
| if ipaddr.IP.To4() != nil || !ipaddr.IP.IsLinkLocalUnicast() { | ||
| continue | ||
| if ipaddr.IP.To4() != nil && (ifi.Flags&net.FlagBroadcast) != 0 { | ||
| keepARP[ifi.Index] = true |
Member
There was a problem hiding this comment.
you can continue here, and no need for the else below, just the if
In case of Layer 2 mode, it doesn't make sense to advertise service load balancer ip on the interfaces which don't have ip configured. This commit filers out those interfaces so that it won't be chosen for sending or responding arp/ndp messages. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
arp-valid-interface
branch
from
539bcee to
4f05c23
Compare
Member
|
LGTM |
fedepaol
added a commit
to fedepaol/metallb
that referenced
this pull request
Jul 15, 2022
A regression introduced by metallb#1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
added a commit
that referenced
this pull request
Jul 15, 2022
A regression introduced by #1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
added a commit
to fedepaol/metallb
that referenced
this pull request
Jul 15, 2022
A regression introduced by metallb#1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
added a commit
that referenced
this pull request
Jul 20, 2022
A regression introduced by #1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
6 tasks
novad03
pushed a commit
to novad03/k8s-meta
that referenced
this pull request
Nov 25, 2023
A regression introduced by metallb/metallb#1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of Layer 2 mode, it doesn't make sense to advertise service
load balancer ip on the interfaces which don't have ip configured.
This commit filers out those interfaces so that it won't be chosen
for sending or responding arp/ndp messages.
Signed-off-by: Periyasamy Palanisamy pepalani@redhat.com