Helm: Add optional annotations for podMonitors and prometheusRules#1407
Helm: Add optional annotations for podMonitors and prometheusRules#1407fedepaol merged 5 commits intometallb:mainfrom
Conversation
8720e71 to
788d8ef
Compare
45579b3 to
e4d24ee
Compare
|
@fedepaol I don't understand the failures, but I reworked the code. I need that someone unlock the CI. |
|
@fedepaol I don't understand the CI failure:
|
oh, the use-operator lane was broken for other reasons (waiting for metallb/metallb-operator#206 to be merged) but this may be some other thing, let me fix it. |
e4d24ee to
b9f2c84
Compare
|
@fedepaol I've rebased on top of main. |
|
The diff looks good to me. @fedepaol are we still waiting on a fix for the operator related CI failures? |
Should be good now, I am trying to keep a fifo approach in open prs (and sorry, I've been busy in the past few days). |
Adding a new note about the new configuration option. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
|
thanks for merging 🙏 |
|
Thanks for the contribution! ❤️ |
My particular use case is adding the following annotation:
Ref: https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types