Skip to content

Helm: Add optional annotations for podMonitors and prometheusRules#1407

Merged
fedepaol merged 5 commits intometallb:mainfrom
sathieu:chart_annotations
Jun 18, 2022
Merged

Helm: Add optional annotations for podMonitors and prometheusRules#1407
fedepaol merged 5 commits intometallb:mainfrom
sathieu:chart_annotations

Conversation

@sathieu
Copy link
Contributor

@sathieu sathieu commented May 31, 2022

My particular use case is adding the following annotation:

argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true

Ref: https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types

@sathieu sathieu force-pushed the chart_annotations branch 2 times, most recently from 8720e71 to 788d8ef Compare May 31, 2022 15:54
@fedepaol
Copy link
Member

fedepaol commented Jun 8, 2022

cc @gclawes

@sathieu mind checking the CI failures?

@sathieu sathieu force-pushed the chart_annotations branch from 45579b3 to e4d24ee Compare June 8, 2022 16:25
@sathieu
Copy link
Contributor Author

sathieu commented Jun 8, 2022

@fedepaol I don't understand the failures, but I reworked the code. I need that someone unlock the CI.

@sathieu
Copy link
Contributor Author

sathieu commented Jun 9, 2022

@fedepaol I don't understand the CI failure:

Error: An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/metallb/metallb/metallb'. No such file or directory

@fedepaol
Copy link
Member

fedepaol commented Jun 9, 2022

@fedepaol I don't understand the CI failure:

Error: An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/metallb/metallb/metallb'. No such file or directory

oh, the use-operator lane was broken for other reasons (waiting for metallb/metallb-operator#206 to be merged) but this may be some other thing, let me fix it.
Your PR doesn't have anything to do with that.

@sathieu sathieu force-pushed the chart_annotations branch from e4d24ee to b9f2c84 Compare June 9, 2022 13:17
@sathieu
Copy link
Contributor Author

sathieu commented Jun 9, 2022

@fedepaol I've rebased on top of main.

@gclawes
Copy link
Contributor

gclawes commented Jun 12, 2022

The diff looks good to me. @fedepaol are we still waiting on a fix for the operator related CI failures?

@fedepaol
Copy link
Member

The diff looks good to me. @fedepaol are we still waiting on a fix for the operator related CI failures?

Should be good now, I am trying to keep a fifo approach in open prs (and sorry, I've been busy in the past few days).
Also, @gclawes if a PR looks good to you, just click the rebase button and after CI is green merge it :-)

@fedepaol fedepaol merged commit 0b0ccf6 into metallb:main Jun 18, 2022
@sathieu sathieu deleted the chart_annotations branch June 20, 2022 08:58
@sathieu
Copy link
Contributor Author

sathieu commented Jun 20, 2022

thanks for merging 🙏

@fedepaol
Copy link
Member

Thanks for the contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants