Cosign images during publish #1437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcarnes
requested review from
fedepaol,
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
Contributor
Author
jtcarnes
changed the title
Contributor
Author
|
@fedepaol whenever you get the chance, lmk |
mattmoor
reviewed
Jul 15, 2022
|
I came here to suggest y'all sign stuff with |
jtcarnes
force-pushed
the
add-cosign
branch
2 times, most recently
from
249ae06 to
70dcd90
Compare
To enable artifact attestation, the images are signed with cosign using the github pipelines oidc token. This makes it easy for artifacts to be verified by external users and is a standard that kubernetes is centering on. Signed-off-by: Joshua Carnes <56089764+jtcarnes@users.noreply.github.com>
Member
|
LGTM, I am gonna test the full release process against my fork tomorrow before merging |
Member
|
Tested on my fork: https://github.com/fedepaol/metallb/actions/runs/2689838188 |
fedepaol
added a commit
to fedepaol/metallb
that referenced
this pull request
Jul 18, 2022
Adding a mention to metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
added a commit
that referenced
this pull request
Jul 19, 2022
Adding a mention to #1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
added a commit
that referenced
this pull request
Jul 20, 2022
Adding a mention to #1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
pperiyasamy
pushed a commit
to pperiyasamy/metallb
that referenced
this pull request
Aug 17, 2022
Adding a mention to metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
pperiyasamy
pushed a commit
to pperiyasamy/metallb
that referenced
this pull request
Sep 6, 2022
Adding a mention to metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
pperiyasamy
pushed a commit
to pperiyasamy/metallb
that referenced
this pull request
Sep 7, 2022
Adding a mention to metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
6 tasks
novad03
pushed a commit
to novad03/k8s-meta
that referenced
this pull request
Nov 25, 2023
Adding a mention to metallb/metallb#1437 Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security, artifact integrity and attestation are important. While a container sha takes care of integrity,
it does not satisfy attestation. The Linux foundations open source Sigstore projects are becoming the
defacto standard for container attestation. Kubernetes latest release was signed with cosign (the
sigstore signing utility).
This MR adds cosign to the release process easily. We use the github actions oidc token to authenticate
to fulcio and receive a short lived key to sign the images after we publish them. This allows
anyone to trivially check where the images have come from and their integrity.
Signing containers in this way is also the standard template for new repos that use github
actions.
Fixes #1423