Repository navigation
Restore MP-BGP - #1444
Merged
Merged
Restore MP-BGP#1444
Conversation
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
June 20, 2022 16:55
fedepaol
force-pushed
the
fix/bgpmp
branch
4 times, most recently
from
June 21, 2022 12:49
a0b3996 to
aa76434
Compare
With MP-BGP, we can advertise the routes to our services regardless of the ip family of the session established with the router. In order to do that, we need to change the configuration so that we announce and we set propertise on prefixes regardless of the session. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We want to be able to instruct the external containers to accept routes regardless of the ip family of the session. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
oribon
reviewed
Jun 21, 2022
| admissionapi "k8s.io/pod-security-admission/api" | ||
| ) | ||
|
|
||
| var _ = ginkgo.Describe("BGP Multipath", func() { |
| var _ = ginkgo.Describe("BGP Multipath", func() { | ||
| var cs clientset.Interface | ||
| var f *framework.Framework | ||
| var nodeToLabel *v1.Node |
| cs = f.ClientSet | ||
| }) | ||
|
|
||
| ginkgo.Context("Multipath", func() { |
Member
There was a problem hiding this comment.
same: multipath -> multiprotocol
| @@ -0,0 +1,228 @@ | |||
| // SPDX-License-Identifier:Apache-2.0 | |||
|
|
|||
| package bgptests | |||
Member
There was a problem hiding this comment.
I think this file was added by mistake, need to squash these changes with the other one?
We add a new set of tests that leverage a dual stack cluster and: - establish a ipv4 / ipv6 only session - check that both the ips of the service work - check that the communities / local prefs are advertised to both the ips of the service Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We want to document that now MP-BGP is available. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Due to the fact that we now support MP-BGP, we have duplicate nexthops because they are received both from the v4 session and the v6 session. We remove the duplicates so we can check the 1:1 mapping with the nodes. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
It helps in triaging test failures. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We are trying to keep the multiprotocol tests (where we enable the external containers to MP) isolated. The dual stack - announce v6 only test must have the external containers enabled to mp, due to the fact that we are announcing one single ip family (v6) but we have two open sessions, so we are moving it. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Expanding the mp coverage with a test that connects both ipfamilies and advertise v4 to both. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Member
|
lgtm |
6 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the way we render the config to accommodate MP-BGP.
We advertise the ips regardless of the ip family of the session established with the neighbor, plus we add e2e tests for that.
Fixes #1402