Merged
Conversation
jtcarnes
requested review from
fedepaol,
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
jtcarnes
force-pushed
the
fix-docker-build
branch
from
9a310fe to
f96ae33
Compare
gclawes
reviewed
Jul 6, 2022
jtcarnes
force-pushed
the
fix-docker-build
branch
from
f96ae33 to
b95fa62
Compare
ARM variants of images were being built with GOARM=6, which was causing issues for users. Added a step in the container builds that maps target platform to variant to ensure they are compiled against the right architecture. Signed-off-by: Joshua Carnes <56089764+jtcarnes@users.noreply.github.com>
jtcarnes
force-pushed
the
fix-docker-build
branch
from
b95fa62 to
6109c3a
Compare
Contributor
|
Good detective work! @fedepaol and I were talking in slack, but I didn't catch the |
Member
|
Testing this and #1479 together in my private repo with https://github.com/fedepaol/metallb/runs/7220821358?check_suite_focus=true |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where binaries were always compiled against GOARM 6, which caused issues for ARM users
(who primarily use arm7). Added a set in container build to map to the correct variant.
I've tested locally and they do appear to work, happy to have someone else test it though.
The command commands build the image, load it locally and when run it'll fail (not in a cluster) but it will show you the architecture it's built for which should be correct.
Fixes #1476