Skip to content

Conversation

@tamcore
Copy link
Contributor

@tamcore tamcore commented Jul 7, 2022

This PR will prevent existing setups from destroying themselves, by raising an exception if configInline is defined.

philipp@ ~/metallb/charts/metallb (patch-2) $ helm template --namespace metallb-system metallb . --set configInline.bla.foo=hi
zsh: correct 'template' to 'templates' [nyae]? n
Error: execution error at (metallb/templates/deprecated_configInline.yaml:2:4): Starting from v0.13.0 configInline is no longer supported. Please see https://metallb.universe.tf/#backward-compatibility

Use --debug flag to render out invalid YAML
philipp@ ~/metallb/charts/metallb (patch-2) $

Signed-off-by: Philipp Born <mail@philipp-born.eu>
@fedepaol
Copy link
Member

fedepaol commented Jul 7, 2022

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants