Change the validating webhook configuration to contain metallb#1497
Change the validating webhook configuration to contain metallb#1497fedepaol merged 3 commits intometallb:mainfrom
Conversation
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
The validating wh configuration is a cluster scoped object, so it makes sense to have its name reference metallb instead of having a generic name that makes it difficult to understand its relationship with metallb. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Updating the release notes of the next version with the new name. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
changewebhookname
branch
from
6e2cd5d to
f9aecc3
Compare
| kind: ValidatingWebhookConfiguration | ||
| metadata: | ||
| name: validating-webhook-configuration | ||
| name: metallb-webhook-configuration |
There was a problem hiding this comment.
Should this be templated? {{ template "metallb.fullname" . }}. Or is it always hardcoded to metallb-webhook-configuration in the code?
There was a problem hiding this comment.
It's hardcoded here https://github.com/metallb/metallb/pull/1497/files#diff-14c68fe5b25ee985e2af6d5dc8c7eaef1b4d91f0dac32019bf971d5681c803beR62 (that's needed for the cert-controller to patch the webhooks), so I guess it's fine as it is.
If we want to make it configurable, we should also change the controller to accept it as a parameter, but I am not sure it's worth the effort.
|
The operator lane is failing because the operator must be aligned to the new name (it won't be an issue when deploying via olm, as the webhook configuration are deployed as part of the csv) |
3 participants
The validating wh configuration is a cluster scoped object, so it makes
sense to have its name reference metallb instead of having a generic
name that makes it difficult to understand its relationship with
metallb.
Fixes #1494