L2: add ndp responders when the address is v6 only #1506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression introduced by metallb#1347, we were adding records to the keepNDP map regardless of the fact that a v6 address was present on the interface. Here we enforce the if checking that the ip is not v4. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
Adding the bug to the release notes. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Contributor
|
LGTM. It would be nice to have some test coverage to prevent regressions. |
Member
Author
Yep, the problem is that docker gets the dual stack and this scenario slipped from CI. I'll try to investigate if there's a way to force v4 only nodes with kind. |
Member
Author
|
Filed #1508 to track the issue |
Contributor
|
Thanks @fedepaol for the fix ! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression introduced by
#1347, we were adding records to
the keepNDP map regardless of the fact that a v6 address was present on
the interface.
Here we enforce the if checking that the ip is not v4.
Fixes #1507
Signed-off-by: Federico Paolinelli fpaoline@redhat.com