Revert "Filter out no IP interfaces for L2 advertisement" - #1516
Merged
Conversation
This reverts commit 9936f3b. There's a use case where metallb is used together with vlan interfaces with no ips which wouldn't work with this change. For this reason, it makes sense to listen and announce on interfaces with no ip.
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
July 18, 2022 10:22
We add the relevant pr to the release notes. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Member
Author
|
Fixes #1511 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9936f3b.
There's a use case where metallb is used together with vlan interfaces
with no ips which wouldn't work with this change.
For this reason, it makes sense to listen and announce on interfaces
with no ip.