Valid pem format to the CRDs webhooks instead empty placeholder

[cyclinder]

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block"

Fixed #1501
Fixed #1521

[fedepaol]

We are trying to have the commit messages as per https://cbea.ms/git-commit/

Can you change the commit with something like:

Add a valid pem format to the CRDs webhooks instead of the empty placeholder

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block" ?

[fedepaol]

Also, can you add another commit to track this change to the release notes here

metallb/website/content/release-notes/_index.md

Line 6 in a942f29

## Version 0.13.4

?

[fedepaol]

Also also, can you change the PR description with the same content as the commit message?

[cyclinder]

Thanks @fedepaol

[cyclinder]

I found "First-time contributors need a maintainer to approve running workflows," Could you enable CI for the PR ?

[fedepaol]

We are trying to have the commit messages as per https://cbea.ms/git-commit/

Can you change the commit with something like:

Add a valid pem format to the CRDs webhooks instead of the empty placeholder

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block" ?

Sorry I wasn't clear. What I meant above was also to change the commit body with the second part here ^^^^ :

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block

Also, the commit title is too long and gets cut, please try to shorten it (Valid pem format to the CRDs webhooks instead empty placeholder should work)

[cyclinder]

We are trying to have the commit messages as per https://cbea.ms/git-commit/
Can you change the commit with something like:
Add a valid pem format to the CRDs webhooks instead of the empty placeholder
We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block" ?

Sorry I wasn't clear. What I meant above was also to change the commit body with the second part here ^^^^ :

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block

Also, the commit title is too long and gets cut, please try to shorten it (Valid pem format to the CRDs webhooks instead empty placeholder should work)

If my understand is right：

PR title: "Valid pem format to the CRDs webhooks instead empty placeholder should work",
First commit message: "Valid pem format to the CRDs webhooks instead empty placeholder should work",
Second commit message: "Release notes: Add a valid pem format to the CRDs webhooks instead of the empty placeholder"

Is this ok?

[fedepaol]

We are trying to have the commit messages as per https://cbea.ms/git-commit/
Can you change the commit with something like:
Add a valid pem format to the CRDs webhooks instead of the empty placeholder
We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block" ?

Sorry I wasn't clear. What I meant above was also to change the commit body with the second part here ^^^^ :

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block

Also, the commit title is too long and gets cut, please try to shorten it (Valid pem format to the CRDs webhooks instead empty placeholder should work)

If my understand is right：

PR title: "Valid pem format to the CRDs webhooks instead empty placeholder should work",
First commit message: "Valid pem format to the CRDs webhooks instead empty placeholder should work",
Second commit message: "Release notes: Add a valid pem format to the CRDs webhooks instead of the empty placeholder"

Is this ok?

PR title: "Valid pem format to the CRDs webhooks instead empty placeholder",
First commit message: "Valid pem format to the CRDs webhooks instead empty placeholder",
Second commit message: "Release notes: mention the cabundle placeholder fix"

Also: add the suggested body:

We need to have a valid format and not only the placeholder, as the apiserver will refuse deletion with "unable to load root certificates: unable to parse bytes as PEM block.

to the first commit

[cyclinder]

@fedepaol Thanks, Updated. Is the Run inv generatemanifests required?

root@master:~/metallb# inv generatemanifests
/bin/bash: line 1: controller-gen: command not found

[fedepaol]

@fedepaol Thanks, Updated. Is the Run inv generatemanifests required?

root@master:~/metallb# inv generatemanifests
/bin/bash: line 1: controller-gen: command not found

nope, I see you changed the manifests manually. CI will complain if they are not consistent with the generated result.

[fedepaol]

The requirements for dev are described here https://metallb.universe.tf/community/#required-software

[fedepaol]

@cyclinder so, CI failed for some difference between the generated manifests under https://github.com/metallb/metallb/tree/main/config/manifests which are generated from the kustomize configuration (including https://github.com/metallb/metallb/blob/main/config/crd/crd-conversion-patch.yaml which you changed).
In order to get it straight, you need to download and install invoke (https://www.pyinvoke.org/) and run inv generatemanifests as CI suggests (please amend the first commit and not add a new one)

[cyclinder]

OK, I am very sorry for not solving the problem in a short time, now I will solve it

[fedepaol]

OK, I am very sorry for not solving the problem in a short time, now I will solve it

no problem, and thanks for the help!

[fedepaol]

Also, come to slack if you need help with that

[fedepaol]

LGTM, thanks!