Remove the pod security policy creation #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod security policy is removed from 1.25, and 1.23 supports pod security admission, so we are definetely migrating away from psp. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Psp is removed in 1.25, and from 1.23 pod security admission is officially supported, so we can safely remove psp. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Instead of deploying on the default namespace, we create the metallb-system namespace and deploy there. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Now inv dev-env deploys on metallb-system with helm too, so we must instruct the tests about it. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
When using servicemonitors, we must grant prometheus access to services and endpoints too. This wasn't failing CI because when deploying prometheus, it's granted permissions against the default namespace. It started to fail when we deployed metallb on a different ns. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod security policy is now not supported anymore, so we remove it.
Note: it's currently not possible to bump the CI up to validate against 1.25 as a 1.25 is not available on kind yet.
I tested it running minikube and checking if the pods get up properly.
Fixes #1401 #1565