L2 SetBalancer: return instead of continue if we find the ip#1570
Merged
fedepaol merged 1 commit intometallb:mainfrom Aug 31, 2022
Merged
L2 SetBalancer: return instead of continue if we find the ip#1570fedepaol merged 1 commit intometallb:mainfrom
fedepaol merged 1 commit intometallb:mainfrom
Conversation
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
In transitioning to dual stack we introduced an issue: if the ip was found, instead of returning the new code continued, grewing the a.ips[name] list on every service update. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In transitioning to dual stack we introduced an issue: if the ip was found, instead of returning the new code continued, grewing the a.ips[name] list on every service update.