Slower debounce time in FRR reloading#1583
Merged
fedepaol merged 3 commits intometallb:mainfrom Sep 6, 2022
Merged
Conversation
fedepaol
requested review from
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
It might be useful to know how long an operation lasts for debugging purpouses. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
It normally takes 2-3 seconds to execute a full reload command. In case of multiple requests in flight, this translates in accumulated requests that end up in pending sighup requests that then translates into allocated memory (basically we have one child frr_reloader process per reload request, consuming memory). In case a service is constantly updated (for example, a dangling endpoint that makes the service available / not available too fast), we may end up accumulating memory that we are not able to free fast (because the number of requests is higher than how fast the reloader can serve them). Because of this, it's safer to accumulate the requests for at least how long it takes to serve one. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
In case the same configuration is propagated to the reloader, we ignore it instead of calling frr again. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In corner cases where we have a bouncing service, the number of updates requested to the reloader is higher than how fast the reloader is able to consume those requests. The requests are mutexed, so what happens is that we have a long (and growing) list of reloader child processes spun up by the sighup that we are not able to estinguish.
This consumes memory and may end up in having the speaker killed.
To fix this, we make the debounce timeout longer
Fixes #1581