Skip to content

Conversation

@liornoy
Copy link
Contributor

@liornoy liornoy commented Sep 7, 2022

This commit updates the information documented about the configmaptocrs tool, due to the recent addition to this tool.
(Added a new way to use the tool directly on the cluster)

To keep the minimal and succinct look of the MetalLB home page, a new page dedicated to the configmaptocrs tool was added and referenced from the home page.

]
}
}'
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

]
}
}'
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an example of the output in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@fedepaol
Copy link
Member

fedepaol commented Sep 7, 2022

Just a few nits!
Thanks!

This commit updates the information documented about the configmaptocrs
tool, due to the recent addition to this tool.
(Added a new way to use the tool directly on the cluster)

To keep the minimal and succinct look of the MetalLB home page,
a new page dedicated to the configmaptocrs tool was added,
and referenced from the home page.

Also updated the configmaptocrs/README.md after the change
of PR metallb#1504 (don't default keepalive time)
@liornoy liornoy force-pushed the update-backward-compatibility-section branch from 12aa8b2 to 2f62130 Compare September 11, 2022 20:30
@fedepaol
Copy link
Member

LGTM, thanks!

@fedepaol fedepaol merged commit c156e2b into metallb:main Sep 13, 2022
@liornoy liornoy deleted the update-backward-compatibility-section branch September 15, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants