chart: add option to set speaker sidecar resources#1622
Merged
fedepaol merged 3 commits intometallb:mainfrom Oct 6, 2022
Merged
chart: add option to set speaker sidecar resources#1622fedepaol merged 3 commits intometallb:mainfrom
fedepaol merged 3 commits intometallb:mainfrom
Conversation
chinnonae
requested review from
fedepaol,
gclawes,
johananl,
oribon,
rata and
russellb
as code owners
Member
|
Thanks! |
Member
|
Ehm, can you either squash the commits or provide context to the second commit on why did you regenerate them? |
Contributor
Author
|
Okay, I've squashed the commits. |
Member
|
Thanks! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to set speaker sidecar resources in helm chart (for these containers, frr, reloader, and frr-metrics)